Re: [PATCH] add definitions for global variables to shell.c

[Robert Schiele <rschiele@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Tue, Aug 19, 2008 at 12:53:21AM -0700, Junio C Hamano wrote:
> Even if that is the case, I do not like the prospect of having to maintain
> a set of duplicated variable definitions.  If we really wanted to address
> this issue, maybe we would want a separate source file that is linked to
> both git-shell and to the rest of the system that has nothing but
> definitions of these variables?  I thought environment.c was meant to be

Ok, so how about globals.c and move just global variables that have at least
two references there?

> something like that -- would linking environment.o pull in too many extra
> references these days (again, I didn't try)?

This pulls in almost everything these days.  In our specific case even the
functions that were redefined in shell.c to start the whole mess.  Thus as
soon as we add environment.c we end up with duplicate symbols on linking
git-shell again.

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."

[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]