From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Imran M Yousuf <imyousuf@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [JGIT RFC] JGit mavenization done right
Date: Tue, 19 Aug 2008 21:52:55 +0200 [thread overview]
Message-ID: <200808192152.55267.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20080819144424.GC20947@spearce.org>
tisdagen den 19 augusti 2008 16.44.24 skrev Shawn O. Pearce:
> Imran M Yousuf <imyousuf@gmail.com> wrote:
> > On Mon, Aug 18, 2008 at 11:55 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > > Imran M Yousuf <imyousuf@gmail.com> wrote:
> > >> I would like to request you all to test out JGit from
> > >> http://repo.or.cz/w/egit/imyousuf.git. Please checkout the branch
> > >> 'unified_tst_rsrc' and try to build it with both maven and Eclipse
> > >> (i.e. as was built earlier)
> >
> > Thanks, it would nice to know whether it works in the original build
> > process or not :).
>
> Well, it did break it in Eclipse:
>
> $ git diff-tree --abbrev -r -M --diff-filter=D orcz-pub/master HEAD
> :100644 000000 9d7d138... 0000000... D org.spearce.jgit.test/.gitignore
> :100644 000000 987d6be... 0000000... D org.spearce.jgit.test/.project
> :100644 000000 8bfa5f1... 0000000... D org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> :100644 000000 fce94cf... 0000000... D org.spearce.jgit.test/.settings/org.eclipse.jdt.ui.prefs
> :100644 000000 304e861... 0000000... D org.spearce.jgit/.classpath
> :100644 000000 ba077a4... 0000000... D org.spearce.jgit/.gitignore
> :100644 000000 7d38455... 0000000... D org.spearce.jgit/.project
> :100644 000000 709a440... 0000000... D org.spearce.jgit/.settings/org.eclipse.jdt.ui.prefs
>
> Removing this stuff was not so good. The Eclipse projects are
> busted and can't be used anymore. We need them back.
>
> The make_jgit.sh however seems to produce a valid JAR. Given the
> file-level differences I didn't expect it to fail.
>
> Also, I wonder if JGitTestUtil is better handled by placing the
> method in RepositoryTestCase and making sure everyone subclasses
> that if they need a test resource file? I'm fairly certain they
> already do, and its a lot easier to invoke a method you inherited
> than one in another class. (Well, easier for the guy writing the
> test case anyway, Java obviously doesn't care either way.)
>
> If we are going to take this in upstream I'd like a flattened/cleaned
> up history. Being able to bisect the misstep of using symlinks
> (the old Maven approach) isn't very valuable in the long-term view
> of the history.
>
> Robin, any thoughts?
Right, I'd also like to see that cleaned up approch in patch form. Cleaning up
helps when preparing for review because one usually find bad stuff during
that process.
-- robin
next prev parent reply other threads:[~2008-08-19 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 4:52 [JGIT RFC] JGit mavenization done right Imran M Yousuf
2008-08-18 5:55 ` Shawn O. Pearce
2008-08-18 6:33 ` Imran M Yousuf
2008-08-19 14:44 ` Shawn O. Pearce
2008-08-19 19:52 ` Robin Rosenberg [this message]
2008-08-20 2:39 ` Imran M Yousuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808192152.55267.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=imyousuf@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).