Git development
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Scott Chacon <schacon@gmail.com>, Jeff King <peff@peff.net>,
	git@vger.kernel.org
Subject: Re: [PATCH] add a 'pre-push' hook
Date: Tue, 19 Aug 2008 16:39:53 -0700	[thread overview]
Message-ID: <20080819233953.GI24212@spearce.org> (raw)
In-Reply-To: <7vy72swpbt.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> "Scott Chacon" <schacon@gmail.com> writes:
> 
> > I would be happy to add the name of the branch being updated and the remote
> > we're trying to push to.  Is there interest then, in the patch?
> 
> [...] so you are in a better position to come up with various use cases
> and the set of parameters the hook would need to do its validation job.

And please be careful with the term "parameters" here.

We not too long ago changed receive-pack to use stdin into a hook
so we don't have to worry about command line length limitations.
Once we start talking about something like push or fetch which can
operate on a huge batch of refs at one shot we really should avoid
the command line limits if we can.

-- 
Shawn.

      reply	other threads:[~2008-08-19 23:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1219170876-46893-1-git-send-email-schacon@gmail.com>
2008-08-19 18:55 ` [PATCH] add a 'pre-push' hook Scott Chacon
2008-08-19 18:58   ` Jeff King
2008-08-19 19:00     ` Scott Chacon
2008-08-19 19:08       ` Jeff King
2008-08-19 19:59         ` Shawn O. Pearce
2008-08-19 20:26           ` Scott Chacon
2008-08-19 21:26             ` しらいしななこ
2008-08-19 21:45               ` Scott Chacon
2008-08-19 22:23                 ` Junio C Hamano
2008-08-19 22:26         ` Sam Vilain
2008-08-20  0:15           ` Jeff King
2008-08-19 19:39       ` Junio C Hamano
2008-08-19 19:58         ` Scott Chacon
2008-08-19 23:35           ` Junio C Hamano
2008-08-19 23:39             ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819233953.GI24212@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=schacon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox