git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] feeding Maildir to git-am
Date: Wed, 20 Aug 2008 09:03:43 -0400	[thread overview]
Message-ID: <20080820130342.GA6602@coredump.intra.peff.net> (raw)
In-Reply-To: <7vbpzotfyy.fsf@gitster.siamese.dyndns.org>

On Tue, Aug 19, 2008 at 10:25:57PM -0700, Junio C Hamano wrote:

> I do not use Maildir myself but people who do not know how Maildir look
> like (including myself) would be left wondering why there is even no error
> message when giving a random directory full of format-patch output to am.

I don't use maildirs with git, but I have worked with them in the past,
and I think your patch is definitely an improvement.

However, I wonder if we could go one step further and just DWYM: if a
directory has "cur" or "new", treat it like a maildir (IOW, look in
there for patches), but otherwise treat it like a directory of
format-patch output.

-Peff

      reply	other threads:[~2008-08-20 13:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20  5:25 [PATCH/RFC] feeding Maildir to git-am Junio C Hamano
2008-08-20 13:03 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080820130342.GA6602@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).