From: Jeff King <peff@peff.net>
To: "MichaelTiloDressel@t-online.de" <MichaelTiloDressel@t-online.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [BUG?] git log does not decorate when custom format is used
Date: Wed, 20 Aug 2008 13:53:25 -0400 [thread overview]
Message-ID: <20080820175325.GD27773@sigill.intra.peff.net> (raw)
In-Reply-To: <1KVmkk-2IOrGi0@fwd26.aul.t-online.de>
On Wed, Aug 20, 2008 at 02:25:30PM +0200, MichaelTiloDressel@t-online.de wrote:
> is it a bug?
Sort of. More like a missing feature.
> When I use something like:
> git log --pretty=format:'%H %s' --decorate
> I do not get the decoration.
> While
> git log --pretty=oneline --decorate
> does decorate.
The problem is where the decoration would go. I think it makes sense not
to show the decoration automatically in that case, since its placement
depends on the user formatting.
The right solution would be a '%d' placeholder to include the
decoration. Patch series to follow:
[1/2] decorate: allow const objects to be decorated
[2/2] allow '%d' pretty format specifier to show decoration
-Peff
next prev parent reply other threads:[~2008-08-20 17:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 12:25 [BUG?] git log does not decorate when custom format is used MichaelTiloDressel
2008-08-20 17:53 ` Jeff King [this message]
2008-08-20 17:55 ` [PATCH 1/2] decorate: allow const objects to be decorated Jeff King
2008-08-20 18:00 ` [PATCH 2/2] allow '%d' pretty format specifier to show decoration Jeff King
2008-08-20 18:32 ` Junio C Hamano
2008-08-20 18:43 ` Johannes Schindelin
2008-08-20 19:01 ` Junio C Hamano
2008-08-20 19:53 ` Johannes Schindelin
2008-09-03 19:36 ` Jeff King
2008-08-20 19:51 ` Michael Dressel
2008-08-20 20:21 ` Junio C Hamano
2008-08-20 21:05 ` Michael Dressel
2008-08-21 5:02 ` "log --pretty=format:" language Teemu Likonen
2008-08-24 18:30 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820175325.GD27773@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=MichaelTiloDressel@t-online.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).