From: Alex Riesen <raa.lkml@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Lea Wiemann <lewiemann@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git am with MIME
Date: Wed, 20 Aug 2008 21:57:34 +0200 [thread overview]
Message-ID: <20080820195734.GE16626@blimp.local> (raw)
In-Reply-To: <20080819170731.GA2424@coredump.intra.peff.net>
Jeff King, Tue, Aug 19, 2008 19:07:31 +0200:
> On Tue, Aug 19, 2008 at 05:50:14PM +0200, Lea Wiemann wrote:
> @@ -107,7 +107,7 @@ static void handle_from(const struct strbuf *from)
> el = strcspn(at, " \n\t\r\v\f>");
> strbuf_reset(&email);
> strbuf_add(&email, at, el);
> - strbuf_remove(&f, at - f.buf, el + 1);
> + strbuf_remove(&f, at - f.buf, el + (at[el] ? 1 : 0));
>
+ strbuf_remove(&f, at - f.buf, el + !!at[el]);
(Some people'll kill me for that :)
next prev parent reply other threads:[~2008-08-20 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 15:50 git am with MIME Lea Wiemann
2008-08-19 17:07 ` Jeff King
2008-08-20 19:57 ` Alex Riesen [this message]
2008-08-20 21:58 ` Jeff King
2008-08-21 3:34 ` Eric Raible
2008-08-21 7:31 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820195734.GE16626@blimp.local \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).