From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: diff --check is stupid about blank lines
Date: Wed, 20 Aug 2008 22:02:01 +0200 [thread overview]
Message-ID: <20080820200201.GA3210@atjola.homenet> (raw)
In-Reply-To: <7vskszr0it.fsf@gitster.siamese.dyndns.org>
On 2008.08.20 11:42:34 -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> > Instead, data.trailing_blanks_start is supposed to be reset to 0 every
> > time we see non-blank newline, a copied context line, or new hunk.
> >
> > So if this triggers with -U0 I'd understand, but otherwise I do not see
> > how.
>
> Ahhh, what idiot wrote the logic for checking trailing blank lines in
> checkdiff_consume().
>
> It does not ask for any context lines. Sheesh.
>
> This should fix it.
Thanks, works for me :-)
Björn
next prev parent reply other threads:[~2008-08-20 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 14:05 diff --check is stupid about blank lines Björn Steinbrink
2008-08-20 17:28 ` Jeff King
2008-08-20 18:13 ` Junio C Hamano
2008-08-20 18:42 ` Junio C Hamano
2008-08-20 20:02 ` Björn Steinbrink [this message]
2008-08-20 22:20 ` Jeff King
2008-08-20 22:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820200201.GA3210@atjola.homenet \
--to=b.steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).