From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH 2/2] Honor ~/.ssh/config whenever possible during SSH based transport
Date: Wed, 20 Aug 2008 22:34:05 +0200 [thread overview]
Message-ID: <200808202234.08348.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1218821705-2631-2-git-send-email-spearce@spearce.org>
fredagen den 15 augusti 2008 19.35.05 skrev Shawn O. Pearce:
> + private void addIdentity(final File identityFile)
> + throws JSchException {
> + final String path = identityFile.getAbsolutePath();
> + if (loadedIdentities.add(path))
> + provider.getJSch().addIdentity(path);
> }
Ok, this breaks 3.3 compatibility and I accidentally pushed it to master. Now Marek also
has stuff that only works (well) with 3.4 becaujse of bugs in 3.3, that won't be fixed. So maybe
we'd better skip 3.3 in order to work faster. I.e. I won't revert this commit, but I am willing to
accept a patch to "fix" it in order to prolong 3.3 compatibilty.
-- robin
next prev parent reply other threads:[~2008-08-20 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 17:35 [EGIT PATCH 1/2] Refactor SSH key loading so we don't duplicate keys Shawn O. Pearce
2008-08-15 17:35 ` [EGIT PATCH 2/2] Honor ~/.ssh/config whenever possible during SSH based transport Shawn O. Pearce
2008-08-20 20:34 ` Robin Rosenberg [this message]
2008-08-20 20:38 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808202234.08348.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).