git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Kevin Ballard <kevin@sb.org>,
	Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: git help broken
Date: Thu, 21 Aug 2008 04:51:11 +0200	[thread overview]
Message-ID: <200808210451.12795.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20080801144121.GU32057@genesis.frugalware.org>

Le vendredi 1 août 2008, Miklos Vajna a écrit :
> On Fri, Aug 01, 2008 at 06:28:52AM +0200, Christian Couder 
<chriscool@tuxfamily.org> wrote:
> > I didn't realize that the function "is_git_command" would not work
> > for "help".
>
> Is there any reason why help is not a builtin? I think that would solve
> the problem.
>
> I'm willing to do such a patch, I just asked in case that would be
> no-go for some - for me - unknown reason.

Sorry I didn't answer before. I was really busy during my vacation ;-P

I think you are right, and in "next" where your patch has been merged, "git 
help help" works fine.

But unfortunately it seems that your patch hasn't been merged into master, 
so "git help help" is still broken there and in git 1.6.0.

Thanks,
Christian.

  parent reply	other threads:[~2008-08-21  2:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 20:52 git help broken Kevin Ballard
2008-07-30 22:38 ` [PATCH] builtin-help: always load_command_list() in cmd_help() Miklos Vajna
2008-07-30 22:50   ` Kevin Ballard
2008-07-30 23:42 ` git help broken Johannes Schindelin
2008-07-30 23:44   ` Johannes Schindelin
2008-07-31  0:04     ` Miklos Vajna
2008-08-01  4:28       ` Christian Couder
2008-08-01 14:41         ` Miklos Vajna
2008-08-02  8:08           ` [PATCH] Builtin git-help Miklos Vajna
2008-08-21  2:51           ` Christian Couder [this message]
2008-08-21 14:21             ` [PATCH] Fix 'git help help' Miklos Vajna
2008-08-22  4:40               ` Christian Couder
2008-07-30 23:45   ` git help broken Kevin Ballard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808210451.12795.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kevin@sb.org \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).