git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bdowning@lavos.net (Brian Downing)
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv3 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs
Date: Thu, 21 Aug 2008 01:29:14 -0500	[thread overview]
Message-ID: <20080821062914.GD31114@lavos.net> (raw)
In-Reply-To: <7vzln7j5yx.fsf@gitster.siamese.dyndns.org>

On Wed, Aug 20, 2008 at 10:24:22PM -0700, Junio C Hamano wrote:
> Is the reason why you mention "incremental" specifically because you only
> tested incremental, or you get identical result in non-incremental mode?

I've only tested incremental at this point.

> If your material is repetitive, say you have lines "A A A B C A A A" in
> the parent blob and "A A A B A A A" in the child blob, and you are trying
> to pass blame on three line block "A A A" at the beginning of the child,
> we can pass blame to the three lines at the beginning part, or to the end
> part, without Linus's common tail trimming optimization.  But there is no
> way it can match the end part with the optimization.
> 
> You cannot say one result is more correct than the other --- both are
> equally correct.  Of course, you could argue that with such a highly
> repetitive material, it may be better to match closer ones, but it's a
> judgement call.

Okay, that makes sense.  Thanks.

-bcd

      reply	other threads:[~2008-08-21  6:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13  7:05 [PATCH 1/2] Make xdiff_outf_{init,release} interface Brian Downing
2008-08-14  0:46 ` Junio C Hamano
2008-08-14  2:06   ` Brian Downing
2008-08-14  2:13     ` Junio C Hamano
2008-08-14  5:13       ` [PATCHv2 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs Brian Downing
2008-08-14  5:13         ` [PATCHv2 2/2] Use strbuf for struct xdiff_emit_state's remainder Brian Downing
2008-08-14  5:31         ` [PATCHv2 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs Brian Downing
2008-08-14  5:36           ` [PATCHv3 " Brian Downing
2008-08-14  5:36             ` [PATCHv3 2/2] Use strbuf for struct xdiff_emit_state's remainder Brian Downing
2008-08-14  6:18             ` [PATCHv3 1/2] Make xdi_diff_outf interface for running xdiff_outf diffs Junio C Hamano
2008-08-14  6:34               ` Brian Downing
2008-08-21  3:37               ` Brian Downing
2008-08-21  5:24                 ` Junio C Hamano
2008-08-21  6:29                   ` Brian Downing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080821062914.GD31114@lavos.net \
    --to=bdowning@lavos.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).