From: "H.Merijn Brand" <h.m.brand@xs4all.nl>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Mike Ralphson <mike@abacus.co.uk>,
git@vger.kernel.org, Mike Ralphson <mike.ralphson@gmail.com>,
Marek Zawirski <marek.zawirski@gmail.com>
Subject: Re: [JGIT PATCH] Typo in implementation of pack protocol
Date: Thu, 21 Aug 2008 17:02:00 +0200 [thread overview]
Message-ID: <20080821170200.3ea08b28@pc09.procura.nl> (raw)
In-Reply-To: <20080821170042.457e62f1@pc09.procura.nl>
On Thu, 21 Aug 2008 17:00:42 +0200, "H.Merijn Brand"
<h.m.brand@xs4all.nl> wrote:
> On Thu, 21 Aug 2008 07:50:12 -0700, "Shawn O. Pearce"
> <spearce@spearce.org> wrote:
>
> > Mike Ralphson <mike@abacus.co.uk> wrote:
> > > cgit's receive-pack.c has never had the corresponding typo.
> > > Fix up method and member names to match.
> >
> > Whoops. Thanks.
> >
> > > - if (line.equals("capabilties^{}")) {
> > > + if (line.equals("capabilities^{}")) {
> > > // special line from git-receive-pack to show
> > > // capabilities when there are no refs to advertise
>
> Wouldn't it be nice to stick to ANSI Comments?
> I bet AIX xlc will fall over very very fast here
Ignore that stupid remark. It's java :(
--
H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
next prev parent reply other threads:[~2008-08-21 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 10:36 [JGIT PATCH] Typo in implementation of pack protocol Mike Ralphson
2008-08-21 14:50 ` Shawn O. Pearce
2008-08-21 15:00 ` H.Merijn Brand
2008-08-21 15:02 ` H.Merijn Brand [this message]
2008-08-21 15:02 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821170200.3ea08b28@pc09.procura.nl \
--to=h.m.brand@xs4all.nl \
--cc=git@vger.kernel.org \
--cc=marek.zawirski@gmail.com \
--cc=mike.ralphson@gmail.com \
--cc=mike@abacus.co.uk \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).