git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] config.mak.in: Pass on LDFLAGS from configure
@ 2008-08-21 19:38 Neil Roberts
  2008-08-22 11:56 ` Andreas Färber
  0 siblings, 1 reply; 2+ messages in thread
From: Neil Roberts @ 2008-08-21 19:38 UTC (permalink / raw)
  To: git

The configure script allows you to specify flags to pass to the linker
step in the LDFLAGS environment variable but this was being ignored in
the Makefile. Now a make variable gets set to the value passed down
from the configure script.

Signed-off-by: Neil Roberts <bpeeluk@yahoo.co.uk>
---

I'm sending this again because I am incompetent. Sorry.

 config.mak.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/config.mak.in b/config.mak.in
index b776149..f67d673 100644
--- a/config.mak.in
+++ b/config.mak.in
@@ -3,6 +3,7 @@
 
 CC = @CC@
 CFLAGS = @CFLAGS@
+LDFLAGS = @LDFLAGS@
 AR = @AR@
 TAR = @TAR@
 #INSTALL = @INSTALL@		# needs install-sh or install.sh in sources
-- 
1.5.4.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] config.mak.in: Pass on LDFLAGS from configure
  2008-08-21 19:38 [PATCH] config.mak.in: Pass on LDFLAGS from configure Neil Roberts
@ 2008-08-22 11:56 ` Andreas Färber
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Färber @ 2008-08-22 11:56 UTC (permalink / raw)
  To: Neil Roberts; +Cc: git


Am 21.08.2008 um 21:38 schrieb Neil Roberts:

> The configure script allows you to specify flags to pass to the linker
> step in the LDFLAGS environment variable but this was being ignored in
> the Makefile. Now a make variable gets set to the value passed down
> from the configure script.
>
> Signed-off-by: Neil Roberts <bpeeluk@yahoo.co.uk>
> ---

> diff --git a/config.mak.in b/config.mak.in
> index b776149..f67d673 100644
> --- a/config.mak.in
> +++ b/config.mak.in
> @@ -3,6 +3,7 @@
>
> CC = @CC@
> CFLAGS = @CFLAGS@
> +LDFLAGS = @LDFLAGS@
> AR = @AR@
> TAR = @TAR@
> #INSTALL = @INSTALL@		# needs install-sh or install.sh in sources
> --

configure also uses CPPFLAGS for preprocessor options like -I/my/path,  
which are dropped as well. Could we fold them into CFLAGS while we're  
at it?

Andreas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-22 11:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-21 19:38 [PATCH] config.mak.in: Pass on LDFLAGS from configure Neil Roberts
2008-08-22 11:56 ` Andreas Färber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).