From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: [EGIT PATCH 00/31] Push GUI, GUI improvements, various jgit stuff Date: Thu, 21 Aug 2008 13:16:36 -0700 Message-ID: <20080821201636.GZ3483@spearce.org> References: <1219005852-21496-1-git-send-email-marek.zawirski@gmail.com> <200808192121.30372.robin.rosenberg.lists@dewire.com> <48AB84A2.7010905@gmail.com> <200808212212.11184.robin.rosenberg.lists@dewire.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Marek Zawirski , git@vger.kernel.org To: Robin Rosenberg X-From: git-owner@vger.kernel.org Thu Aug 21 22:18:22 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KWGbF-0002et-Bd for gcvg-git-2@gmane.org; Thu, 21 Aug 2008 22:17:41 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324AbYHUUQi (ORCPT ); Thu, 21 Aug 2008 16:16:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754383AbYHUUQi (ORCPT ); Thu, 21 Aug 2008 16:16:38 -0400 Received: from george.spearce.org ([209.20.77.23]:48058 "EHLO george.spearce.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbYHUUQh (ORCPT ); Thu, 21 Aug 2008 16:16:37 -0400 Received: by george.spearce.org (Postfix, from userid 1001) id E33F238375; Thu, 21 Aug 2008 20:16:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <200808212212.11184.robin.rosenberg.lists@dewire.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Robin Rosenberg wrote: > onsdagen den 20 augusti 2008 04.42.42 skrev Marek Zawirski: > > Actually, I'm now leaving for few days, so I'm sending out just fixes > > for issues pointed out by Shawn and found by me in the mean time. I'll > > squash these patches with existing commits in push branch, as it is > > probably worth nothing to keep this in history. > > As I'm too eager to get this out (seems to work), I can squash it and > rearrange the checkbox-related code a little like stealing the icons > from the Eclipse CVS and grouping the checkbox classes with the > icons plus a tweak for selecting how the images for the checkbox > are created. Yea. Go for it. Reusing icons from Eclipse CVS is a good way around the icon issue. -- Shawn.