From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: Nicolas Pitre <nico@cam.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack
Date: Fri, 22 Aug 2008 15:27:21 +0200 [thread overview]
Message-ID: <200808221527.21971.johan@herland.net> (raw)
In-Reply-To: <200808221439.31219.johan@herland.net>
On Friday 22 August 2008, Johan Herland wrote:
> (I don't have time to look into this right now, but will do so later
> if nobody comes up with a solution in the meantime...)
>
> When running 'git verify-pack -v' on multiple packs (.idx files), it
> fails for all packs, except the first, with exit code 128, and the
> following single line:
>
> fatal: internal error: pack revindex fubar
>
> This does not happen when given only a single pack, or when given
> multiple packs, but without '-v' option.
>
> To reproduce, simply do:
>
> git verify-pack -v .git/objects/pack/*.idx
>
> in any repo with more than one pack file.
>
> This happens with a fairly current 'next' (1.6.0.96.g2fad1). AFAICS,
> it also happens in v1.6.0.
Bisection point to this commit:
commit 1f5c74f6cf918d317c73b328dcd4cf6f55c44d8a
Author: Nicolas Pitre <nico@cam.org>
Date: Mon Jun 23 21:22:14 2008 -0400
call init_pack_revindex() lazily
This makes life much easier for next patch, as well as being more efficient
when the revindex is actually not used.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2008-08-22 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 12:39 [BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack Johan Herland
2008-08-22 13:27 ` Johan Herland [this message]
2008-08-22 13:45 ` [PATCH] Selftest for verifying 'git verify-pack -v' with multiple arguments Johan Herland
2008-08-22 13:49 ` [BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack Nicolas Pitre
2008-08-22 19:45 ` [PATCH] discard revindex data when pack list changes Nicolas Pitre
2008-08-22 21:57 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808221527.21971.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).