From: Johan Herland <johan@herland.net>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] discard revindex data when pack list changes
Date: Fri, 22 Aug 2008 23:57:04 +0200 [thread overview]
Message-ID: <200808222357.04912.johan@herland.net> (raw)
In-Reply-To: <alpine.LFD.1.10.0808221540290.1624@xanadu.home>
On Friday 22 August 2008, Nicolas Pitre wrote:
> This is needed to fix verify-pack -v with multiple pack arguments.
>
> Also, in theory, revindex data (if any) must be discarded whenever
> reprepare_packed_git() is called. In practice this is hard to trigger
> though.
>
> Signed-off-by: Nicolas Pitre <nico@cam.org>
Tested-by: Johan Herland <johan@herland.net>
Thanks. Works for me :)
Junio: if you added the my testcase, please squash the following into this
patch before applying:
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index 339375a..83abe5f 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -186,7 +186,7 @@ test_expect_success \
test-2-${packname_2}.idx \
test-3-${packname_3}.idx'
-test_expect_failure \
+test_expect_success \
'verify pack -v' \
'git verify-pack -v test-1-${packname_1}.idx \
test-2-${packname_2}.idx \
--
1.6.0.96.g2fad1
Have fun! :)
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
prev parent reply other threads:[~2008-08-22 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 12:39 [BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack Johan Herland
2008-08-22 13:27 ` Johan Herland
2008-08-22 13:45 ` [PATCH] Selftest for verifying 'git verify-pack -v' with multiple arguments Johan Herland
2008-08-22 13:49 ` [BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack Nicolas Pitre
2008-08-22 19:45 ` [PATCH] discard revindex data when pack list changes Nicolas Pitre
2008-08-22 21:57 ` Johan Herland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808222357.04912.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).