From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: robert_no.spam_m@yahoo.fr, git@vger.kernel.org
Subject: Re: [egit PATCH] avoiding output in the error log
Date: Wed, 27 Aug 2008 15:00:22 -0700 [thread overview]
Message-ID: <20080827220022.GP26523@spearce.org> (raw)
In-Reply-To: <200808272350.56819.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> > >
> > > Shawn, you removed the test from the code in 4a230ea1. Perhaps you could care to
> > > comment on this patch to restore the test, though slightly different.
> > >
> > > if (r.isAccessible())
> > > r.setSessionProperty(GITFOLDERDIRTYSTATEPROPERTY, null);
>
> Good. So then the question is whether we should use isAccessible() or exists()? Normally
> this makes no difference, but for a Project (at least) there is a difference. I project that exits
> is not accessible when closed.
It _has_ to be isAccessible(). You cannot get or set a session
property on a closed project.
--
Shawn.
prev parent reply other threads:[~2008-08-27 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 9:34 [egit PATCH] avoiding output in the error log robert_no.spam_m
2008-08-27 20:28 ` Robin Rosenberg
2008-08-27 20:33 ` Shawn O. Pearce
2008-08-27 21:50 ` Robin Rosenberg
2008-08-27 22:00 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827220022.GP26523@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robert_no.spam_m@yahoo.fr \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).