From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH] Change GitResourceDecorator to use isAccessible
Date: Fri, 29 Aug 2008 11:01:06 +0200 [thread overview]
Message-ID: <200808291101.06253.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1219968506-30437-1-git-send-email-spearce@spearce.org>
fredagen den 29 augusti 2008 02.08.26 skrev Shawn O. Pearce:
> f3a6ac20 says it switched to use isAccessible() here but it
> changed to exists(). We can only use setSessionProperty if
> the resource is accessible so we must use the correct test
> here in order to fix the issue reported by Robert.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>
> I just pushed this out to master since you clearly meant
> for this to be the case. :-|
Thanks. I had a fix, but noticed the attribution was wrong so I fixed
the patch again and forgot the fix.
-- robin
prev parent reply other threads:[~2008-08-29 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 0:08 [EGIT PATCH] Change GitResourceDecorator to use isAccessible Shawn O. Pearce
2008-08-29 9:01 ` Robin Rosenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808291101.06253.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).