From: Heikki Orsila <shd@modeemi.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Replace "git-" with "git " in *.[ch] comments and notifications
Date: Sat, 30 Aug 2008 12:54:11 +0300 [thread overview]
Message-ID: <20080830095411.GA28666@jolt.modeemi.cs.tut.fi> (raw)
In-Reply-To: <7vr6872qv1.fsf@gitster.siamese.dyndns.org>
On Fri, Aug 29, 2008 at 07:12:18PM -0700, Junio C Hamano wrote:
> I however am not sure if posting a single patch that is 1300 lines long
> would be the most effective way to achieve that goal. Splitting them into
> a handful batches, spread over a few weeks to give reviewers some
> breathing room, might make it more reviewable. I dunno.
>
> [CUT]
>
> One thing you might be able to do would be to separate user visible
> strings and in-comment strings.
>
> [CUT]
> ... would cause git-init to fail here...
> ... would cause "init" to fail here...
>
> than:
>
> ... would cause git init to fail here...
>
> Among these three, I think the second one is the most readable.
Okay, will split patches into smaller ones, distribute them over time,
and use the second form for _in-comment_ strings. User visible strings
will say "git init".
--
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd
next prev parent reply other threads:[~2008-08-30 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 23:47 [PATCH] Replace "git-" with "git " in *.[ch] comments and notifications Heikki Orsila
2008-08-30 0:56 ` Junio C Hamano
2008-08-30 1:15 ` Heikki Orsila
2008-08-30 2:12 ` Junio C Hamano
2008-08-30 9:54 ` Heikki Orsila [this message]
2008-08-30 10:08 ` Andreas Ericsson
2008-08-30 11:29 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080830095411.GA28666@jolt.modeemi.cs.tut.fi \
--to=shd@modeemi.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).