git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Schiele <rschiele@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] change Perl syntax to support Perl 5.6
Date: Sat, 30 Aug 2008 19:39:47 +0200	[thread overview]
Message-ID: <20080830173947.GF7185@schiele.dyndns.org> (raw)

git-add--interactive has one Perl command that was not yet present in
Perl 5.6.  Changing this single command makes it compatible again.

Signed-off-by: Robert Schiele <rschiele@gmail.com>
---
This is an alternative to my previous patch that just declared Perl 5.8 to
be the required version.

 git-add--interactive.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index da768ee..777ec5f 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -61,7 +61,7 @@ sub run_cmd_pipe {
 		return qx{@args};
 	} else {
 		my $fh = undef;
-		open($fh, '-|', @_) or die;
+		open($fh, '-|', join(' ', @_)) or die;
 		return <$fh>;
 	}
 }
-- 
1.5.4.5

             reply	other threads:[~2008-08-30 17:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30 17:39 Robert Schiele [this message]
2008-08-30 18:00 ` [PATCH] change Perl syntax to support Perl 5.6 Jeff King
2008-08-30 18:06   ` Junio C Hamano
2008-08-30 18:13     ` Jeff King
2008-08-30 18:34     ` Robert Schiele
2008-08-30 18:39       ` Jeff King
2008-08-30 20:37         ` Jakub Narebski
2008-08-30 21:21           ` Robert Schiele
2008-08-31  5:35           ` Avery Pennarun
2008-08-31 13:37             ` Randal L. Schwartz
2008-08-31 16:27               ` Junio C Hamano
2008-08-31 18:29                 ` Avery Pennarun
2008-08-31 20:23                   ` Jakub Narebski
2008-08-31 20:34                     ` Petr Baudis
2008-09-01  3:57                       ` H. Peter Anvin
2008-09-01  4:22                         ` Robert Schiele
2008-09-01 13:06                           ` Tom G. Christensen
2008-09-04 17:28                             ` Brandon Casey
2008-09-05  6:34                               ` Tom G. Christensen
2008-08-31 20:55                     ` Jakub Narebski
2008-09-01  1:52             ` Jay Soffian
2008-09-01 21:42             ` Alex Riesen
2008-09-02  0:23               ` Avery Pennarun
2008-09-02 17:50                 ` Avery Pennarun
2008-08-30 20:20       ` Junio C Hamano
2008-08-31 13:35 ` Randal L. Schwartz
2008-08-31 19:54 ` Ask Bjørn Hansen
2008-09-01  1:22   ` Junio C Hamano
2008-09-01  1:48     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080830173947.GF7185@schiele.dyndns.org \
    --to=rschiele@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).