git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Avery Pennarun <apenwarr@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	"Randal L. Schwartz" <merlyn@stonehenge.com>,
	Jeff King <peff@peff.net>, Robert Schiele <rschiele@gmail.com>,
	git@vger.kernel.org, Lea Wiemann <lewiemann@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] change Perl syntax to support Perl 5.6
Date: Sun, 31 Aug 2008 22:34:27 +0200	[thread overview]
Message-ID: <20080831203427.GF10360@machine.or.cz> (raw)
In-Reply-To: <200808312223.38222.jnareb@gmail.com>

On Sun, Aug 31, 2008 at 10:23:36PM +0200, Jakub Narebski wrote:
> On Sub, 31 August 2008, Avery Pennarun wrote:
> > I have a proper implementation in the 'runlock' script in gitbuilder:
> > 
> >     http://github.com/apenwarr/gitbuilder/tree/master/runlock
> > 
> > In that particular case, I wanted to handle signals carefully, so I
> > needed the manual fork thing even in perl 5.8.  You can safely remove
> > the signal handling stuff (and of course the lockfile stuff) if you
> > just want a minimal safe fork-exec-wait implementation in perl.
> 
> But if we go this way, i.e. fork+exec (perhaps implicit fork), why do
> not simply use appropriate commands from Git.pm (Git::Repo doesn't
> have it yet, IIRC).  As far as I remember Git.pm was created initially
> to unify all different "safe_pipe" and "safe_cmd" implementations among
> different Perl scripts in Git (Petr "Pasky" Baudis CC-ed).

Can anyone give a concrete justification for Perl 5.6 support? Who is
needing it and why do they have to use Perl 5.6? Does it offset the time
spent discussing and reviewing this and the maintenance burden of extra
complicated code?

-- 
				Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC.  -- Bill Gates

  reply	other threads:[~2008-08-31 20:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30 17:39 [PATCH] change Perl syntax to support Perl 5.6 Robert Schiele
2008-08-30 18:00 ` Jeff King
2008-08-30 18:06   ` Junio C Hamano
2008-08-30 18:13     ` Jeff King
2008-08-30 18:34     ` Robert Schiele
2008-08-30 18:39       ` Jeff King
2008-08-30 20:37         ` Jakub Narebski
2008-08-30 21:21           ` Robert Schiele
2008-08-31  5:35           ` Avery Pennarun
2008-08-31 13:37             ` Randal L. Schwartz
2008-08-31 16:27               ` Junio C Hamano
2008-08-31 18:29                 ` Avery Pennarun
2008-08-31 20:23                   ` Jakub Narebski
2008-08-31 20:34                     ` Petr Baudis [this message]
2008-09-01  3:57                       ` H. Peter Anvin
2008-09-01  4:22                         ` Robert Schiele
2008-09-01 13:06                           ` Tom G. Christensen
2008-09-04 17:28                             ` Brandon Casey
2008-09-05  6:34                               ` Tom G. Christensen
2008-08-31 20:55                     ` Jakub Narebski
2008-09-01  1:52             ` Jay Soffian
2008-09-01 21:42             ` Alex Riesen
2008-09-02  0:23               ` Avery Pennarun
2008-09-02 17:50                 ` Avery Pennarun
2008-08-30 20:20       ` Junio C Hamano
2008-08-31 13:35 ` Randal L. Schwartz
2008-08-31 19:54 ` Ask Bjørn Hansen
2008-09-01  1:22   ` Junio C Hamano
2008-09-01  1:48     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080831203427.GF10360@machine.or.cz \
    --to=pasky@suse.cz \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hpa@zytor.com \
    --cc=jnareb@gmail.com \
    --cc=lewiemann@gmail.com \
    --cc=merlyn@stonehenge.com \
    --cc=peff@peff.net \
    --cc=rschiele@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).