Git development
 help / color / mirror / Atom feed
From: Heikki Orsila <shdl@zakalwe.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: Heikki Orsila <heikki.orsila@iki.fi>, git@vger.kernel.org
Subject: Re: [PATCH] Correct documentation wording for diff options -S and --pickaxe-all
Date: Mon, 1 Sep 2008 02:59:57 +0300	[thread overview]
Message-ID: <20080831235957.GB16289@zakalwe.fi> (raw)
In-Reply-To: <7v63pg3h4o.fsf@gitster.siamese.dyndns.org>

On Sun, Aug 31, 2008 at 04:21:43PM -0700, Junio C Hamano wrote:
> Thanks, but if we are doing this, we should reword it to something less
> misleading.  The pickaxe search does not look for changes that contains
> string in the sense people might expect (e.g. "diff -u0 | grep string").
> 
> The machinery looks at the old and new copy, and considers it a match if
> they have different numbers of "string" in them.
> 
> So perhaps something like this
> 
> -S<string>::
> 	Look for differences that changes the number of <string> in the
> 	file.
> 
> --pickaxe-all::
> 	When -S finds a change, show all the changes in that changeset,
>         not just the files for which the number of <string> in them
> 	changes.
> 
> but I am bad at writing, so I'll ask others to come up with a better
> wording.

Perhaps like this:

-S:
"Look for differences that change the number of <string> matches in a file.
In other words, moving the <string> inside a file does not imply a 
match, but adding or removing <string> will."

-- 
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd

      reply	other threads:[~2008-09-01  0:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-31 23:03 [PATCH] Correct documentation wording for diff options -S and --pickaxe-all Heikki Orsila
2008-08-31 23:21 ` Junio C Hamano
2008-08-31 23:59   ` Heikki Orsila [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080831235957.GB16289@zakalwe.fi \
    --to=shdl@zakalwe.fi \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=heikki.orsila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox