From: Eric Wong <normalperson@yhbt.net>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: Feature request: git-svn dcommit should send deltas upstream
Date: Sun, 31 Aug 2008 20:41:47 -0700 [thread overview]
Message-ID: <20080901034127.GA22120@untitled> (raw)
In-Reply-To: <87y72dkvq4.fsf@mid.deneb.enyo.de>
Florian Weimer <fw@deneb.enyo.de> wrote:
> * Florian Weimer:
>
> >> It's been too long since I've looked at the SVN TxDelta API, but I
> >> thought SVN::TxDelta::apply would take care of the delta computation for
> >> us...
> >
> > SVN::Git::Editor::M does not seem to make use of the base text.
>
> Here's an attempt at delta generation. I don't know if it is entirely
> correct, but it does work in the sense that it passes "make test" and
> the test cases I reported eariler.
Thanks Florian.
Works for me, here. I've also tested this editing an audio file and
transmitting it over the wire without any trouble. I've added one more
patch on top of your series to check the (undef) return value of
send_txstream.
Acked and pushed out to git://git.bogomips.org/git-svn.git along
with Thomas's other patch.
--
Eric Wong
next prev parent reply other threads:[~2008-09-01 3:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 10:54 Feature request: git-svn dcommit should send deltas upstream Florian Weimer
2008-08-29 8:23 ` Eric Wong
2008-08-29 10:17 ` Florian Weimer
2008-08-31 16:14 ` Florian Weimer
2008-08-31 17:03 ` Junio C Hamano
2008-08-31 17:13 ` Florian Weimer
2008-09-01 3:41 ` Eric Wong [this message]
2008-09-01 8:09 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901034127.GA22120@untitled \
--to=normalperson@yhbt.net \
--cc=fw@deneb.enyo.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).