From: Abhijit Menon-Sen <ams@toroid.org>
To: git@vger.kernel.org
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
"Tom G. Christensen" <tgc@statsbiblioteket.dk>,
Petr Baudis <pasky@suse.cz>
Subject: [PATCH] Git.pm: Require File::Temp 0.14 for new()
Date: Mon, 1 Sep 2008 15:34:35 +0530 [thread overview]
Message-ID: <20080901100435.GC6555@toroid.org> (raw)
In-Reply-To: <vpqvdxggpw6.fsf@bauges.imag.fr>
File::Temp->new() was introduced in File::Temp 0.14, but 5.8.0 shipped
with File::Temp 0.13, as pointed out by Tom G. Christensen. Since the
dependency is optional anyway, we can require 0.14.
Signed-off-by: Abhijit Menon-Sen <ams@toroid.org>
---
At 2008-09-01 11:46:17 +0200, Matthieu.Moy@imag.fr wrote:
>
> > The problem is that Git.pm depends on the "new" method of File::Temp
> > introduced in 0.14. [...]
>
> Isn't that fixed by c14c8ceb13b299892f286757e22e6af4f6cffab5 ?
> (Git.pm: Make File::Spec and File::Temp requirement lazy, a few
> commits before 1.6.0)
No, because _verify_require only checks that File::Temp exists, not that
File::Temp 0.14 exists. This patch fixes that.
-- ams
perl/Git.pm | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 102e6a4..4e901b6 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -1032,7 +1032,10 @@ sub _temp_cache {
}
sub _verify_require {
- eval { require File::Temp; require File::Spec; };
+ eval {
+ require File::Spec;
+ require File::Temp; File::Temp->VERSION(0.14);
+ };
$@ and throw Error::Simple($@);
}
--
1.6.0.49.gea35
next prev parent reply other threads:[~2008-09-01 10:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 9:27 Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen
2008-09-01 9:46 ` Matthieu Moy
2008-09-01 10:04 ` Abhijit Menon-Sen [this message]
2008-09-01 10:21 ` [PATCH] Git.pm: Require File::Temp 0.14 for new() Tom G. Christensen
2008-09-01 10:42 ` [PATCH] Git.pm: Use File::Temp->tempfile instead of ->new Abhijit Menon-Sen
2008-09-01 11:03 ` Tom G. Christensen
2008-09-07 5:27 ` Junio C Hamano
2008-09-07 9:26 ` Abhijit Menon-Sen
2008-09-07 16:50 ` Marcus Griep
2008-09-08 8:05 ` Abhijit Menon-Sen
2008-09-08 15:51 ` Marcus Griep
2008-09-08 16:53 ` [PATCH v2] " Marcus Griep
2008-09-09 1:53 ` Eric Wong
2008-09-10 3:53 ` Junio C Hamano
2008-09-10 10:09 ` Eric Wong
2008-09-09 2:06 ` Abhijit Menon-Sen
2008-09-09 17:35 ` Marcus Griep
2008-09-09 7:41 ` Tom G. Christensen
2008-09-09 17:55 ` Marcus Griep
2008-09-10 7:16 ` Tom G. Christensen
2008-09-10 15:09 ` [PATCH] git-svn: Fixes my() parameter list syntax error in pre-5.8 Perl Marcus Griep
2008-09-10 15:11 ` Marcus Griep
2008-09-01 10:13 ` Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901100435.GC6555@toroid.org \
--to=ams@toroid.org \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=tgc@statsbiblioteket.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).