From: Abhijit Menon-Sen <ams@toroid.org>
To: "Tom G. Christensen" <tgc@statsbiblioteket.dk>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>,
Petr Baudis <pasky@suse.cz>
Subject: [PATCH] Git.pm: Use File::Temp->tempfile instead of ->new
Date: Mon, 1 Sep 2008 16:12:22 +0530 [thread overview]
Message-ID: <20080901104222.GA10026@toroid.org> (raw)
In-Reply-To: <48BBC20E.20808@statsbiblioteket.dk>
Perl 5.8.0 ships with File::Temp 0.13, which does not have the new()
interface introduced in 0.14, as pointed out by Tom G. Christensen.
Signed-off-by: Abhijit Menon-Sen <ams@toroid.org>
---
At 2008-09-01 12:21:02 +0200, tgc@statsbiblioteket.dk wrote:
>
> Wouldn't it be possible to accomplish the same as File::Temp->New with
> the old File::Temp?
OK, does this one work for you?
-- ams
perl/Git.pm | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 102e6a4..f383ff8 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -1021,10 +1021,13 @@ sub _temp_cache {
carp "Temp file '", $name,
"' was closed. Opening replacement.";
}
- $$temp_fd = File::Temp->new(
- TEMPLATE => 'Git_XXXXXX',
- DIR => File::Spec->tmpdir
- ) or throw Error::Simple("couldn't open new temp file");
+ eval {
+ ($$temp_fd) = File::Temp->tempfile(
+ 'Git_XXXXXX',
+ DIR => File::Spec->tmpdir
+ );
+ };
+ throw Error::Simple("couldn't open new temp file") if $@;
$$temp_fd->autoflush;
binmode $$temp_fd;
}
--
1.6.0.1.161.g7f314
next prev parent reply other threads:[~2008-09-01 10:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 9:27 Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen
2008-09-01 9:46 ` Matthieu Moy
2008-09-01 10:04 ` [PATCH] Git.pm: Require File::Temp 0.14 for new() Abhijit Menon-Sen
2008-09-01 10:21 ` Tom G. Christensen
2008-09-01 10:42 ` Abhijit Menon-Sen [this message]
2008-09-01 11:03 ` [PATCH] Git.pm: Use File::Temp->tempfile instead of ->new Tom G. Christensen
2008-09-07 5:27 ` Junio C Hamano
2008-09-07 9:26 ` Abhijit Menon-Sen
2008-09-07 16:50 ` Marcus Griep
2008-09-08 8:05 ` Abhijit Menon-Sen
2008-09-08 15:51 ` Marcus Griep
2008-09-08 16:53 ` [PATCH v2] " Marcus Griep
2008-09-09 1:53 ` Eric Wong
2008-09-10 3:53 ` Junio C Hamano
2008-09-10 10:09 ` Eric Wong
2008-09-09 2:06 ` Abhijit Menon-Sen
2008-09-09 17:35 ` Marcus Griep
2008-09-09 7:41 ` Tom G. Christensen
2008-09-09 17:55 ` Marcus Griep
2008-09-10 7:16 ` Tom G. Christensen
2008-09-10 15:09 ` [PATCH] git-svn: Fixes my() parameter list syntax error in pre-5.8 Perl Marcus Griep
2008-09-10 15:11 ` Marcus Griep
2008-09-01 10:13 ` Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901104222.GA10026@toroid.org \
--to=ams@toroid.org \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=tgc@statsbiblioteket.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).