From: Heikki Orsila <shd@modeemi.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add --filedirstat diff option
Date: Tue, 2 Sep 2008 14:58:49 +0300 [thread overview]
Message-ID: <20080902115848.GA1252@jolt.modeemi.cs.tut.fi> (raw)
In-Reply-To: <7vd4jnnifp.fsf@gitster.siamese.dyndns.org>
On Mon, Sep 01, 2008 at 11:57:46PM -0700, Junio C Hamano wrote:
> Heikki Orsila <heikki.orsila@iki.fi> writes:
>
> > @@ -2474,7 +2478,10 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
> > options->output_format |= DIFF_FORMAT_DIRSTAT;
> > else if (!strcmp(arg, "--cumulative"))
> > options->output_format |= DIFF_FORMAT_CUMULATIVE;
> > - else if (!strcmp(arg, "--check"))
> > + else if (opt_arg(arg, 'X', "filedirstat", &options->dirstat_percent)) {
> > + options->output_format |= DIFF_FORMAT_DIRSTAT;
> > + options->filedirstat = 1;
>
> Why 'X'? It would never match, confusing to the reader, and risks a
> sudden change in behaviour when these statements are reordered or somebody
> mechanically attempts to convert this to parse_options().
This is embarrassing.. I just copied the previous "dirstat" line..
*grin*
Anyway, what about the concept of filedirstat? Is it agreeable?
--
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd
next prev parent reply other threads:[~2008-09-02 12:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 1:12 [PATCH] Add --filedirstat diff option Heikki Orsila
2008-09-02 6:57 ` Junio C Hamano
2008-09-02 11:58 ` Heikki Orsila [this message]
2008-09-02 23:40 ` Junio C Hamano
2008-09-02 23:55 ` Junio C Hamano
2008-09-03 0:08 ` Heikki Orsila
2008-09-03 0:28 ` Re* " Junio C Hamano
2008-09-03 0:39 ` Heikki Orsila
2008-09-03 0:12 ` Jeff King
2008-09-03 0:18 ` Heikki Orsila
2008-09-03 0:44 ` Junio C Hamano
2008-09-03 12:47 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2008-09-02 23:51 Heikki Orsila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902115848.GA1252@jolt.modeemi.cs.tut.fi \
--to=shd@modeemi.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).