git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Teach "log -F --author=<match>" to behave better
Date: Thu, 4 Sep 2008 16:33:44 +0300	[thread overview]
Message-ID: <20080904133344.GA3197@mithlond.arda.local> (raw)
In-Reply-To: <7vprnk5n3c.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano wrote (2008-09-04 01:31 -0700):

> To handle --author=<match> request, the code created a grep
> instruction that tried to match a line that begins with 'author ' and
> <match> somewhere on the same line.  "begins with 'author '" obviously
> needs to be expressed with an regexp '^author '.
> 
> When the user specifies --fixed-string, this does not work at all.

> This extends the grep machinery so that a match insn can ignore user
> specified --fixed-string request, and uses the '( -e A --and -e B )'
> construct from the grep machinery in order to express "has to begin
> with '^author ', and also the same line must match the given pattern".

I want to add a side note here because this _may_ be related to what 
I found almost two months ago:

    "Patterns work unexpectedly with 'git log' commit limiting"
    http://thread.gmane.org/gmane.comp.version-control.git/88813

One of the problems was that with

    git log -E --author=pattern

the pattern is interpreted as basic regexp but with 

    git log --author=pattern -E

as extended rexexp.

  reply	other threads:[~2008-09-04 13:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04  6:47 git rev-list --author/--committer b0rked with -F/--fixed-strings Giuseppe Bilotta
2008-09-04  7:12 ` Junio C Hamano
2008-09-04  8:31   ` [PATCH] Teach "log -F --author=<match>" to behave better Junio C Hamano
2008-09-04 13:33     ` Teemu Likonen [this message]
2008-09-04 19:06       ` Junio C Hamano
2008-09-04 19:25         ` Teemu Likonen
2008-09-05  1:04           ` Junio C Hamano
2008-09-04 13:56     ` Giuseppe Bilotta
2008-09-04 14:09     ` Petr Baudis
2008-09-04 19:34       ` Junio C Hamano
2008-09-05 12:35         ` --all-match Teemu Likonen
2008-09-05  4:47       ` [PATCH] Teach "log -F --author=<match>" to behave better Junio C Hamano
2008-09-04 13:46   ` git rev-list --author/--committer b0rked with -F/--fixed-strings Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080904133344.GA3197@mithlond.arda.local \
    --to=tlikonen@iki.fi \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=giuseppe.bilotta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).