From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO
Date: Sun, 7 Sep 2008 23:21:59 +0200 [thread overview]
Message-ID: <200809072321.59789.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1220821208-13420-1-git-send-email-spearce@spearce.org>
söndagen den 7 september 2008 23.00.08 skrev Shawn O. Pearce:
> From: Shawn O. Pearce <sop@google.com>
>
> The reverse sort was using the initial pending queue, not the
> generator that comes before it in the workflow. This caused
> a combination of TOPO and REVERSE to return no commits.
Some unit tests to back this up would be nice. We running low on
coverage in this section of code.
> Signed-off-by: Shawn O. Pearce <sop@google.com>
No idea Google employees had this short email addresses. Ok, 27x27x27 = 19683
would be sufficient in theory, I'd suppose.
-- robin
next prev parent reply other threads:[~2008-09-07 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 21:00 [JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO Shawn O. Pearce
2008-09-07 21:03 ` Shawn O. Pearce
2008-09-07 21:21 ` Robin Rosenberg [this message]
2008-09-07 21:32 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809072321.59789.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).