git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Abhijit Menon-Sen <ams@toroid.org>
To: Marcus Griep <marcus@griep.us>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
	Junio C Hamano <gitster@pobox.com>,
	"Tom G. Christensen" <tgc@statsbiblioteket.dk>
Subject: Re: [PATCH v2] Git.pm: Use File::Temp->tempfile instead of ->new
Date: Tue, 9 Sep 2008 07:36:05 +0530	[thread overview]
Message-ID: <20080909020605.GA19190@toroid.org> (raw)
In-Reply-To: <1220892781-24343-1-git-send-email-marcus@griep.us>

At 2008-09-08 12:53:01 -0400, marcus@griep.us wrote:
>
> +		my $fname;
> +		($$temp_fd, $fname) = File::Temp->tempfile(
> +			'Git_XXXXXX', UNLINK => 1
>  			) or throw Error::Simple("couldn't open new temp file");

What happens when tempfile croaks on error?

-- ams

  parent reply	other threads:[~2008-09-09  2:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01  9:27 Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen
2008-09-01  9:46 ` Matthieu Moy
2008-09-01 10:04   ` [PATCH] Git.pm: Require File::Temp 0.14 for new() Abhijit Menon-Sen
2008-09-01 10:21     ` Tom G. Christensen
2008-09-01 10:42       ` [PATCH] Git.pm: Use File::Temp->tempfile instead of ->new Abhijit Menon-Sen
2008-09-01 11:03         ` Tom G. Christensen
2008-09-07  5:27           ` Junio C Hamano
2008-09-07  9:26             ` Abhijit Menon-Sen
2008-09-07 16:50               ` Marcus Griep
2008-09-08  8:05                 ` Abhijit Menon-Sen
2008-09-08 15:51                   ` Marcus Griep
2008-09-08 16:53                     ` [PATCH v2] " Marcus Griep
2008-09-09  1:53                       ` Eric Wong
2008-09-10  3:53                         ` Junio C Hamano
2008-09-10 10:09                           ` Eric Wong
2008-09-09  2:06                       ` Abhijit Menon-Sen [this message]
2008-09-09 17:35                         ` Marcus Griep
2008-09-09  7:41                       ` Tom G. Christensen
2008-09-09 17:55                         ` Marcus Griep
2008-09-10  7:16                           ` Tom G. Christensen
2008-09-10 15:09                             ` [PATCH] git-svn: Fixes my() parameter list syntax error in pre-5.8 Perl Marcus Griep
2008-09-10 15:11                               ` Marcus Griep
2008-09-01 10:13   ` Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080909020605.GA19190@toroid.org \
    --to=ams@toroid.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=marcus@griep.us \
    --cc=normalperson@yhbt.net \
    --cc=tgc@statsbiblioteket.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).