From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/4] is_directory(): a generic helper function
Date: Tue, 9 Sep 2008 08:32:07 -0400 [thread overview]
Message-ID: <20080909123207.GA25799@coredump.intra.peff.net> (raw)
In-Reply-To: <48C6508B.1080600@viscovery.net>
On Tue, Sep 09, 2008 at 12:31:39PM +0200, Johannes Sixt wrote:
> Junio C Hamano schrieb:
> > +/*
> > + * Do not use this for inspecting *tracked* content. When path is a
> > + * symlink to a directory, we do not want to say it is a directory.
>
> I though stat(2) checks the thing that a symlink points to. Then either
> this comment is not correct or you want to use lstat(2), no?
I assume he meant "do not use this for tracked content, because in that
case...". But I had to read it twice to make sense.
> > + * Worth yet, leading components in path could contain symbolic links.
And this didn't help. I assume it should be "worse yet" and Junio
developed some sort of typing lisp?
-Peff
next prev parent reply other threads:[~2008-09-09 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 8:27 [PATCH 0/4] Pushing into a repository with alternates Junio C Hamano
2008-09-09 8:27 ` [PATCH 1/4] is_directory(): a generic helper function Junio C Hamano
2008-09-09 8:27 ` [PATCH 2/4] receive-pack: make it a builtin Junio C Hamano
2008-09-09 8:27 ` [PATCH 3/4] push: prepare sender to receive extended ref information from the receiver Junio C Hamano
2008-09-09 8:27 ` [PATCH 4/4] push: receiver end advertises refs from alternate repositories Junio C Hamano
2008-09-09 13:03 ` [PATCH 3/4] push: prepare sender to receive extended ref information from the receiver Jeff King
2008-09-09 9:26 ` [PATCH 2/4] receive-pack: make it a builtin Paolo Bonzini
2008-09-09 14:24 ` Junio C Hamano
2008-09-09 14:47 ` Paolo Bonzini
2008-09-09 10:31 ` [PATCH 1/4] is_directory(): a generic helper function Johannes Sixt
2008-09-09 12:32 ` Jeff King [this message]
2008-09-09 14:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909123207.GA25799@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).