git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: arjen@yaph.org (Arjen Laarhoven)
To: Mike Ralphson <mike.ralphson@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] Use compatibility regex library for OSX/Darwin
Date: Wed, 10 Sep 2008 12:03:01 +0200	[thread overview]
Message-ID: <20080910100301.GA27748@regex.yaph.org> (raw)
In-Reply-To: <e2b179460809100103t4266650bnac00097cfb86c0b1@mail.gmail.com>

On Wed, Sep 10, 2008 at 09:03:05AM +0100, Mike Ralphson wrote:
> 2008/9/7 Arjen Laarhoven <arjen@yaph.org>
> > The standard libc regex library on OSX does not support alternation
> > in POSIX Basic Regular Expression mode.  This breaks the diff.funcname
> > functionality on OSX.
> >
> > Also, I'm sure the problem occurs on more non-Linux systems (or non
> > GNU libc systems).  If people who have access to those systems (BSD's,
> > HP-UX, AIX, etc) can test it, I'd be happy to add those systems to the
> > patch so it can fix for multiple systems at once.
> 
> I can confirm that the issue shown up by your new testcase is also
> present in AIX 5.3.

Ok, I'll add AIX to the fix and a Tested-by: line.

[snip]

> Adding -lcompat/regex to COMPAT_CFLAGS as per your Darwin hunk
> provokes lots of warnings:

I think your problem is a lowercase ell instead of an uppercase i ;-)

Arjen

-- 
Arjen Laarhoven

The presence of those seeking the truth is infinitely to be preferred to 
those who think they've found it.
                                -- Terry Pratchett, "Monstrous Regiment"

  parent reply	other threads:[~2008-09-10 10:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-07 18:45 [RFC/PATCH] Use compatibility regex library for OSX/Darwin Arjen Laarhoven
2008-09-10  8:03 ` Mike Ralphson
2008-09-10  9:49   ` Johannes Sixt
2008-09-10 10:03   ` Arjen Laarhoven [this message]
2008-09-10 11:53     ` Mike Ralphson
2008-09-11  7:59       ` Mike Ralphson
2008-09-11  8:14         ` [PATCH] Use compatibility regex library also on AIX Johannes Sixt
2008-09-11  8:25           ` Arjen Laarhoven
2008-09-11  8:31             ` Mike Ralphson
2008-09-11 12:12               ` Jeff King
2008-09-11  8:27           ` Junio C Hamano
2008-09-16 17:49 ` [RFC/PATCH] Use compatibility regex library for OSX/Darwin Brandon Casey
2008-09-16 18:09   ` Junio C Hamano
2008-09-18  0:08     ` [PATCH 1/4] diff.c: return pattern entry pointer rather than just the hunk header pattern Brandon Casey
2008-09-18  0:10     ` [PATCH 2/4] diff.c: associate a flag with each pattern and use it for compiling regex Brandon Casey
2008-09-18  4:14       ` Junio C Hamano
2008-09-18  6:41         ` Andreas Ericsson
2008-09-18  7:12           ` Junio C Hamano
2008-09-18  8:06             ` Andreas Ericsson
2008-09-18  8:35               ` Junio C Hamano
2008-09-18  0:10     ` [PATCH 3/4] diff.*.xfuncname which uses "extended" regex's for hunk header selection Brandon Casey
     [not found]       ` <7vd4j212gb.fsf@gitster.siamese.dyndns.org>
2008-09-19 18:14         ` Brandon Casey
2008-09-18  0:21     ` [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions Brandon Casey
2008-09-18  0:33       ` [PATCH 4/4 v2] " Brandon Casey
2008-09-18  7:18       ` [PATCH 4/4] " Andreas Ericsson
2008-09-18  7:31         ` Junio C Hamano
2008-09-18  8:39       ` Johan Herland
2008-09-18 10:15         ` Gustaf Hendeby
2008-09-18 10:53       ` Jonathan del Strother
2008-09-18 15:48         ` Brandon Casey
2008-09-16 19:08   ` [RFC/PATCH] Use compatibility regex library for OSX/Darwin Jeff King
2008-09-16 23:25   ` Boyd Lynn Gerber
2008-09-16 23:32     ` Jeff King
2008-09-16 23:42       ` Boyd Lynn Gerber
2008-09-16 23:46         ` Jeff King
2008-09-17  0:10           ` Boyd Lynn Gerber
2008-09-17  0:13             ` Brandon Casey
2008-09-17  0:13           ` Boyd Lynn Gerber
2008-09-17  0:20             ` Brandon Casey
2008-09-17  0:38               ` Boyd Lynn Gerber
2008-09-17  0:58                 ` Brandon Casey
2008-09-17  1:02           ` Boyd Lynn Gerber
2008-09-17  1:25             ` Brandon Casey
2008-09-17 14:48               ` Boyd Lynn Gerber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080910100301.GA27748@regex.yaph.org \
    --to=arjen@yaph.org \
    --cc=git@vger.kernel.org \
    --cc=mike.ralphson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).