git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Christian Stimming <stimming@tuhh.de>
Cc: Alexander Gavrilov <angavrilov@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: I18n fix sentence parts into full sentences for translation again.
Date: Fri, 12 Sep 2008 08:39:34 -0700	[thread overview]
Message-ID: <20080912153934.GG22960@spearce.org> (raw)
In-Reply-To: <200809121232.14364.stimming@tuhh.de>

Christian Stimming <stimming@tuhh.de> wrote:
> Am Freitag, 12. September 2008 12:23 schrieb Alexander Gavrilov:
> > On Fri, Sep 12, 2008 at 1:17 PM, Christian Stimming <stimming@tuhh.de> 
> wrote:
> > >-       set op_question [mc "Force resolution to %s?
> > >-Note that the diff shows only conflicting changes.
> > >+    set op_question [strcat $targetquestion "\n" \
> > >+[mc "Note that the diff shows only conflicting changes.
> >
> > ...
> >
> > > -               $target [short_path $current_diff_path]]
> > > +               $targetquestion [short_path $current_diff_path]]]
> >
> > You should remove this $target completely -- there is no %s to match it
> > anymore.
> 
> Oh - right. Thanks for pointing this out. Please modify the patch accordingly.

Fixed and applied.  Thanks, both.

-- 
Shawn.

      reply	other threads:[~2008-09-12 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12  9:17 [PATCH] git-gui: I18n fix sentence parts into full sentences for translation again Christian Stimming
2008-09-12 10:23 ` Alexander Gavrilov
2008-09-12 10:32   ` Christian Stimming
2008-09-12 15:39     ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080912153934.GG22960@spearce.org \
    --to=spearce@spearce.org \
    --cc=angavrilov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=stimming@tuhh.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).