git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Brown <git@davidb.org>
To: Dhruva Krishnamurthy <dhruva@ymail.com>
Cc: GIT SCM <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Optional shrinking of RCS keywords in git-p4
Date: Sun, 14 Sep 2008 23:09:55 -0700	[thread overview]
Message-ID: <20080915060954.GA32347@linode.davidb.org> (raw)
In-Reply-To: <1221458331-8804-1-git-send-email-dhruva@ymail.com>

On Mon, Sep 15, 2008 at 11:28:51AM +0530, Dhruva Krishnamurthy wrote:

>Modifying RCS keywords prevents submitting to p4 from git due to missing hunks.
>New option git-p4.kwstrip set to true or false controls the behavior.

I'm a little curious about what the problem here is.  I've been
stripping keywords out of P4 and submitting changes for many years,
and never had a problem.

I'm just wondering if we're not fixing the wrong problem here.

David

  reply	other threads:[~2008-09-15  6:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-15  5:58 [PATCH] Optional shrinking of RCS keywords in git-p4 Dhruva Krishnamurthy
2008-09-15  6:09 ` David Brown [this message]
2008-09-15  6:17 ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2008-09-15  6:26 dhruva
2008-09-15  6:35 ` David Brown
2008-09-15  7:43   ` Junio C Hamano
2008-09-15 11:02     ` Tor Arvid Lund
2008-09-15 19:22     ` Daniel Barkalow
2008-09-16  4:12       ` David Brown
2008-09-16 12:58         ` Jing Xue
2008-09-16 17:12         ` Daniel Barkalow
2008-09-16 17:32           ` Daniel Barkalow
2008-09-15  6:31 dhruva
2008-09-15  7:21 dhruva
2008-09-15 11:46 dhruva
2008-09-15 15:27 ` Tor Arvid Lund
2008-09-16  2:51 dhruva
2008-09-16  4:53 dhruva
2008-09-16 17:26 ` Daniel Barkalow
2008-09-16 13:33 dhruva
2008-09-19  2:56 dhruva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080915060954.GA32347@linode.davidb.org \
    --to=git@davidb.org \
    --cc=dhruva@ymail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).