From: David Brown <git@davidb.org>
To: dhruva <dhruva@ymail.com>
Cc: GIT SCM <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Simon Hausmann <simon@lst.de>
Subject: Re: [PATCH] Optional shrinking of RCS keywords in git-p4
Date: Sun, 14 Sep 2008 23:35:21 -0700 [thread overview]
Message-ID: <20080915063521.GA1533@linode.davidb.org> (raw)
In-Reply-To: <16219.81556.qm@web95005.mail.in2.yahoo.com>
On Mon, Sep 15, 2008 at 11:56:22AM +0530, dhruva wrote:
>8. The git diffs is now not aware of the change in RCS keyword
>9. You try to submit your local changes back to p4
>10. Applying your local changes as patch sets will fail with missing hunks tracking RCS keyword changes
It sounds like you are trying to apply these as patches to a tree
which doesn't have RCS headers. As far as I can tell, P4 completely
ignores whatever the $Id: ...$ headers happen to be expanded to at the
time of checking. You can put garbage there, and it check in fine.
I've been checking in files for many years with stripped headers. I
wrote a python script years ago to strip the P4 headers after Perforce
was unwilling to implement this as an option.
I guess it isn't a problem to make this optional in git-p4, but I
don't think this patch is solving the right problem.
David
next prev parent reply other threads:[~2008-09-15 6:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 6:26 [PATCH] Optional shrinking of RCS keywords in git-p4 dhruva
2008-09-15 6:35 ` David Brown [this message]
2008-09-15 7:43 ` Junio C Hamano
2008-09-15 11:02 ` Tor Arvid Lund
2008-09-15 19:22 ` Daniel Barkalow
2008-09-16 4:12 ` David Brown
2008-09-16 12:58 ` Jing Xue
2008-09-16 17:12 ` Daniel Barkalow
2008-09-16 17:32 ` Daniel Barkalow
-- strict thread matches above, loose matches on Subject: below --
2008-09-19 2:56 dhruva
2008-09-16 13:33 dhruva
2008-09-16 4:53 dhruva
2008-09-16 17:26 ` Daniel Barkalow
2008-09-16 2:51 dhruva
2008-09-15 11:46 dhruva
2008-09-15 15:27 ` Tor Arvid Lund
2008-09-15 7:21 dhruva
2008-09-15 6:31 dhruva
2008-09-15 5:58 Dhruva Krishnamurthy
2008-09-15 6:09 ` David Brown
2008-09-15 6:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915063521.GA1533@linode.davidb.org \
--to=git@davidb.org \
--cc=dhruva@ymail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).