git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Deskin Miller <deskinm@umich.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-svn: do a partial rebuild if rev_map is out-of-date
Date: Wed, 17 Sep 2008 23:38:04 -0700	[thread overview]
Message-ID: <20080918063754.GA13328@untitled> (raw)
In-Reply-To: <20080917031304.GA2505@riemann.deskinm.fdns.net>

Deskin Miller <deskinm@umich.edu> wrote:
> This commit will have git-svn do a partial rebuild of the rev_map to
> match the true state of the branch, if it ever is used to fetch again.
> 
> This will only work for projects not using either noMetadata or
> useSvmProps configuration options; if you are using these options,
> git-svn will fall back to the previous behaviour.
> 
> Signed-off-by: Deskin Miller <deskinm@umich.edu>
> ---

Hi Deskin,

This seems to break the following test case for me:

*** t9107-git-svn-migrate.sh ***
*   ok 1: setup old-looking metadata
*   ok 2: git-svn-HEAD is a real HEAD
*   ok 3: initialize old-style (v0) git svn layout
*   ok 4: initialize a multi-repository repo
*   ok 5: multi-fetch works on partial urls + paths
*   ok 6: migrate --minimize on old inited layout
* FAIL 7: .rev_db auto-converted to .rev_map.UUID

I haven't had time to diagnose it.  Also, can you add a test that
demonstrates this functionality (and ensures things keeps working when
future work is done on git-svn?)

Thanks.

-- 
Eric Wong

  reply	other threads:[~2008-09-18  6:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-17  3:13 [PATCH] git-svn: do a partial rebuild if rev_map is out-of-date Deskin Miller
2008-09-18  6:38 ` Eric Wong [this message]
2008-09-21  2:45   ` [PATCH v2 0/1] git-svn: testcase for partial rebuild Deskin Miller
2008-09-22  4:12     ` Eric Wong
2008-09-21  2:45   ` [PATCH v2 1/1] git-svn: do a partial rebuild if rev_map is out-of-date Deskin Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080918063754.GA13328@untitled \
    --to=normalperson@yhbt.net \
    --cc=deskinm@umich.edu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).