From: Eric Wong <normalperson@yhbt.net>
To: Florian Ragwitz <rafl@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add git-svn branch to allow branch creation in SVN repositories
Date: Wed, 17 Sep 2008 23:55:16 -0700 [thread overview]
Message-ID: <20080918065516.GA28905@untitled> (raw)
In-Reply-To: <1221142839-29624-1-git-send-email-rafl@debian.org>
Florian Ragwitz <rafl@debian.org> wrote:
> Signed-off-by: Florian Ragwitz <rafl@debian.org>
Hi Florian, Sorry I haven't checked the list (nor a good chunk email) in
a bit.
The patch looks good, but can you add a test for this functionality?
It'll make maintenance easier when other people (myself included)
introduce changes that can potentially break something. Thanks.
> ---
> Documentation/git-svn.txt | 24 +++++++++++++++++++++++-
> git-svn.perl | 43 ++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 65 insertions(+), 2 deletions(-)
>
--
Eric Wong
next prev parent reply other threads:[~2008-09-18 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 14:20 [PATCH] Add git-svn branch to allow branch creation in SVN repositories Florian Ragwitz
2008-09-18 6:55 ` Eric Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-05 11:34 Florian Ragwitz
2008-09-07 2:33 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918065516.GA28905@untitled \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=rafl@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).