From: Petr Baudis <pasky@suse.cz>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [TopGit PATCH] tg-patch: add From/Date: line to header and print to file
Date: Mon, 22 Sep 2008 17:39:38 +0200 [thread overview]
Message-ID: <20080922153938.GP10360@machine.or.cz> (raw)
In-Reply-To: <1221818101-14333-2-git-send-email-bert.wesarg@googlemail.com>
On Fri, Sep 19, 2008 at 11:55:01AM +0200, Bert Wesarg wrote:
> To make this more similar to git format-patch, I added a 'From' and
> a 'Date:' header and let 'tg patch' print to a file (which is shown as output).
>
> Regards
> Bert
>
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
I dislike the anyway completely bogus From line. If you want mbox
format, you should call (hypothetical) tg mail. Also, IMHO Date: should
be simply always printed at the end of the header, it's distracting if
it is higher.
Also, the writing to file is confusing to me. What are you trying to
achieve? If you want to export patches, why not use 'tg export' which
already has this functionality? To me, 'tg patch' is basically
equivalent of 'git show' for the whole branch.
--
Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC. -- Bill Gates
next prev parent reply other threads:[~2008-09-22 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 9:55 [TopGit PATCH] prev/next/tsort: commands to explore dependencies Bert Wesarg
2008-09-19 9:55 ` [TopGit PATCH] tg-patch: add From/Date: line to header and print to file Bert Wesarg
2008-09-22 15:39 ` Petr Baudis [this message]
2008-09-22 18:10 ` Bert Wesarg
2008-09-22 15:36 ` [TopGit PATCH] prev/next/tsort: commands to explore dependencies Petr Baudis
2008-09-22 17:32 ` Bert Wesarg
2008-09-22 20:10 ` Uwe Kleine-König
2008-09-22 20:18 ` Bert Wesarg
2008-09-24 15:23 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922153938.GP10360@machine.or.cz \
--to=pasky@suse.cz \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).