From: Miklos Vajna <vmiklos@frugalware.org>
To: Deskin Miller <deskinm@umich.edu>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] maint: check return of split_cmdline to avoid bad config strings
Date: Thu, 25 Sep 2008 00:32:52 +0200 [thread overview]
Message-ID: <20080924223252.GL23137@genesis.frugalware.org> (raw)
In-Reply-To: <20080924145029.GA3052@riemann.deskinm.fdns.net>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Wed, Sep 24, 2008 at 10:50:29AM -0400, Deskin Miller <deskinm@umich.edu> wrote:
> As the testcase demonstrates, it's possible for split_cmdline to return -1 and
> deallocate any memory it's allocated, if the config string is missing an end
> quote. In both the cases below, which are the only calling sites, the return
> isn't checked, and using the pointer causes a pretty immediate segfault.
>
> Signed-off-by: Deskin Miller <deskinm@umich.edu>
Acked-by: Miklos Vajna <vmiklos@frugalware.org>
Thanks.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-09-24 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 6:10 [PATCH] maint: check return of split_cmdline to avoid bad config strings Deskin Miller
2008-09-24 9:28 ` Miklos Vajna
2008-09-24 14:50 ` [PATCH v2] " Deskin Miller
2008-09-24 22:32 ` Miklos Vajna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924223252.GL23137@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=deskinm@umich.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).