From: "Shawn O. Pearce" <spearce@spearce.org>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Help identify aspell version on Windows too
Date: Fri, 26 Sep 2008 07:28:18 -0700 [thread overview]
Message-ID: <20080926142818.GW3669@spearce.org> (raw)
In-Reply-To: <48DCA5F3.4090009@isy.liu.se>
Gustaf Hendeby <hendeby@isy.liu.se> wrote:
> >> }
> >> - set s_version [string range $s_version 5 end]
> >> + set s_version [string range [string trim $s_version] 5 end]
> >
> > A strange indentation you have here.
>
> Yep, sorry about that, seems I had a nonstandard tab-width setting. Too
> bad not all projects can decide on the same tab width. :( Will resend
> if there are no other comments to this, and at the same time fix the
> spelling in the commit message...
I fixed the indentation, but didn't notice the spelling error in
the commit message. Anyway, its too late, I have already pushed
this fix out to my maint and master branches in git-gui. I'm not
going to rewind 'em.
--
Shawn.
prev parent reply other threads:[~2008-09-26 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 21:31 [PATCH] git-gui: Help identify aspell version on Windows too Gustaf Hendeby
2008-09-26 6:29 ` Johannes Sixt
2008-09-26 9:05 ` Gustaf Hendeby
2008-09-26 9:31 ` Johannes Sixt
2008-09-26 14:31 ` Shawn O. Pearce
2008-09-26 15:06 ` Johannes Sixt
2008-09-26 14:28 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926142818.GW3669@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=hendeby@isy.liu.se \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).