git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* git-stash.sh: don't default to refs/stash if invalid ref supplied
@ 2008-09-26 15:19 Brandon Casey
  2008-09-26 15:25 ` Shawn O. Pearce
  0 siblings, 1 reply; 2+ messages in thread
From: Brandon Casey @ 2008-09-26 15:19 UTC (permalink / raw)
  To: Shawn O. Pearce; +Cc: Git Mailing List



   commit da65e7c133cd316c9076fbb6b0aeee7bc42a6db8
   Author: Brandon Casey <casey@nrlssc.navy.mil>
   Date:   Tue Sep 23 18:57:09 2008 -0500

       git-stash.sh: don't default to refs/stash if invalid ref supplied
    
       <snip>
    
       e.g. 'git stash apply stash@{1}' would fall back to
            'git stash apply stash@{0}'


heh, you fixed my spelling "mistake" :), but it wasn't a mistake. Originally
I had:

    e.g. 'git stash apply stahs@{1}' would fall back to
         'git stash apply stash@{0}'

intending to show that a simple spelling mistake could cause the wrong thing
to be done. The example in the commit message could actually still happen if
there was only a single stash entry. I guess I should have used 'foobar@{1}'. :)

-brandon

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: git-stash.sh: don't default to refs/stash if invalid ref supplied
  2008-09-26 15:19 git-stash.sh: don't default to refs/stash if invalid ref supplied Brandon Casey
@ 2008-09-26 15:25 ` Shawn O. Pearce
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn O. Pearce @ 2008-09-26 15:25 UTC (permalink / raw)
  To: Brandon Casey; +Cc: Git Mailing List

Brandon Casey <casey@nrlssc.navy.mil> wrote:
>    commit da65e7c133cd316c9076fbb6b0aeee7bc42a6db8
>    Author: Brandon Casey <casey@nrlssc.navy.mil>
>    Date:   Tue Sep 23 18:57:09 2008 -0500
> 
>        git-stash.sh: don't default to refs/stash if invalid ref supplied
>     
>        <snip>
>     
>        e.g. 'git stash apply stash@{1}' would fall back to
>             'git stash apply stash@{0}'
> 
> heh, you fixed my spelling "mistake" :), but it wasn't a mistake. Originally
> I had:

Heh.  I geuss my spleling meter was working overtime yesterday?  ;-)

>     e.g. 'git stash apply stahs@{1}' would fall back to
>          'git stash apply stash@{0}'
> 
> intending to show that a simple spelling mistake could cause the wrong thing
> to be done. The example in the commit message could actually still happen if
> there was only a single stash entry. I guess I should have used 'foobar@{1}'. :)

Yea, reading it now I see why you had the typo in the message.
But yesterday it just looked like a typo to me.  Dammit.  That's
the last time I cleanup a typo before applying a patch!

;-)

-- 
Shawn.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-26 15:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-26 15:19 git-stash.sh: don't default to refs/stash if invalid ref supplied Brandon Casey
2008-09-26 15:25 ` Shawn O. Pearce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).