From: Dmitry Potapov <dpotapov@gmail.com>
To: Marcus Griep <marcus@griep.us>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Alex Riesen <raa.lkml@gmail.com>,
Johannes Sixt <johannes.sixt@telecom.at>
Subject: Re: [PATCH 4/4] cygwin: Use native Win32 API for stat
Date: Sat, 27 Sep 2008 20:33:50 +0400 [thread overview]
Message-ID: <20080927163349.GE21650@dpotapov.dyndns.org> (raw)
In-Reply-To: <347507080809270851y79764dbcgba1ef5a1d58bdd3e@mail.gmail.com>
On Sat, Sep 27, 2008 at 11:51:24AM -0400, Marcus Griep wrote:
>
> Overall, looks good, though Alex's comment of using "cygwin.nativestat" may
> be a better descriptor for the config flag.
Perhaps... but I am not sure about policy for options in config file.
core.cygwinnativestat was proposed by Shawn, so I would like to hear
his opinion.
> I also think there is more refactoring that could be done, with there being
> common code paths still existing in MinGW and Cygwin.
I am not sure that there is much common code left: stat structures are
different in MinGW and Cygwin (different fields and their types), and I
do not think having one function with a lot of #ifdef __CYGWIN__ in it
is actual improvement. But you can send a patch on top of mine and let
other people decide if it is a worty goal.
Dmitry
next prev parent reply other threads:[~2008-09-27 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 8:43 [PATCH 4/4] cygwin: Use native Win32 API for stat Dmitry Potapov
[not found] ` <347507080809270851y79764dbcgba1ef5a1d58bdd3e@mail.gmail.com>
2008-09-27 16:33 ` Dmitry Potapov [this message]
2008-09-27 18:35 ` Johannes Sixt
2008-09-27 21:54 ` Dmitry Potapov
2008-09-28 9:24 ` Johannes Sixt
2008-09-29 15:34 ` Shawn O. Pearce
2008-09-29 18:26 ` Dmitry Potapov
2008-09-30 13:53 ` [PATCH 4/4 v2] " Dmitry Potapov
2008-09-30 14:57 ` Marcus Griep
2008-09-30 20:26 ` Shawn O. Pearce
2008-09-28 9:50 ` [PATCH 4/4] " Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080927163349.GE21650@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
--cc=marcus@griep.us \
--cc=raa.lkml@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).