From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Habouzit Subject: Re: git-describe doesn't show the most recent tag Date: Sun, 28 Sep 2008 17:03:18 +0200 Message-ID: <20080928150318.GI5302@artemis.corp> References: <20080928135526.GG5302@artemis.corp> <20080928143949.GH5302@artemis.corp> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="u/L2/WlOHZg+YGU4"; protocol="application/pgp-signature"; micalg=SHA1 Cc: "git@vger.kernel.org" , open-iscsi@googlegroups.com To: Erez Zilber X-From: git-owner@vger.kernel.org Sun Sep 28 17:04:35 2008 connect(): Connection refused Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kjxp1-0006as-Gw for gcvg-git-2@gmane.org; Sun, 28 Sep 2008 17:04:32 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbYI1PDV (ORCPT ); Sun, 28 Sep 2008 11:03:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751786AbYI1PDV (ORCPT ); Sun, 28 Sep 2008 11:03:21 -0400 Received: from pan.madism.org ([88.191.52.104]:43166 "EHLO hermes.madism.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbYI1PDU (ORCPT ); Sun, 28 Sep 2008 11:03:20 -0400 Received: from madism.org (olympe.madism.org [82.243.245.108]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "artemis.madism.org", Issuer "madism.org" (verified OK)) by hermes.madism.org (Postfix) with ESMTPS id B7FA2305E0; Sun, 28 Sep 2008 17:03:19 +0200 (CEST) Received: by madism.org (Postfix, from userid 1000) id 4BE312AC9C; Sun, 28 Sep 2008 17:03:18 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20080928143949.GH5302@artemis.corp> X-Face: $(^e[V4D-[`f2EmMGz@fgWK!e.B~2g.{08lKPU(nc1J~z\4B>*JEVq:E]7G-\6$Ycr4<;Z!|VY6Grt]+RsS$IMV)f>2)M="tY:ZPcU;&%it2D81X^kNya0=L]"vZmLP+UmKhgq+u*\.dJ8G!N&=EvlD User-Agent: Madmutt/devel (Linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: --u/L2/WlOHZg+YGU4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 28, 2008 at 02:39:49PM +0000, Pierre Habouzit wrote: > On Sun, Sep 28, 2008 at 02:29:21PM +0000, Erez Zilber wrote: > > On Sun, Sep 28, 2008 at 4:55 PM, Pierre Habouzit = wrote: > > > On Sun, Sep 28, 2008 at 01:48:42PM +0000, Erez Zilber wrote: > > >> Why is this happening? > > > > > > --tags > > > Instead of using only the annotated tags, use any tag found= in > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > .git/refs/tags. > > > > >=20 > > I'm not sure that I understand the difference between tags and annotate= d tags. >=20 > a lightweight tag is just a reference. an annotated tag has a message > associated. Usually tags are meant as local help, whereas annotated tags > are the ones pushed to the repositories and that never change. That's > why many tools ignore non annotated tags by default unless you pass > --tags to them. >=20 > > Anyway, if I move to the master branch, I see the following tags: > >=20 > > [erez.zilber@erez-lx:/tmp/open-iscsi.git]$ ls .git/refs/tags/ > > 2.0-868-rc1 2.0-869 2.0-869.1 2.0-869.2 2.0-869-rc2 2.0-869-rc3 > > 2.0-869-rc4 2.0-870-rc1 > > [erez.zilber@erez-lx:/tmp/open-iscsi.git]$ git-tag > > 2.0-868-rc1 > > 2.0-869 > > 2.0-869-rc2 > > 2.0-869-rc3 > > 2.0-869-rc4 > > 2.0-869.1 > > 2.0-869.2 > > 2.0-870-rc1 > >=20 > > However: > > [erez.zilber@erez-lx:/tmp/open-iscsi.git]$ git-describe --tags > > 2.0-868-rc1-81-g31c9d42 > >=20 > > I was expecting to see 2.0-870-rc1 here. Scratch my previous answer, I was confused with too many digits (868 vs 870). In fact looking at the code, if there is an annotated tag in the ancestry, git describe will always prefer it to lightweight tags. the problem with lightweight tags is that they are meant to be moved, hence are not really something you want to base on to chose a uuid (which git-describe generates). --=20 =C2=B7O=C2=B7 Pierre Habouzit =C2=B7=C2=B7O madcoder@debia= n.org OOO http://www.madism.org --u/L2/WlOHZg+YGU4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkjfnLYACgkQvGr7W6Hudhz6dQCfcA3stLikz9VVUvNb3jRREEhl SwoAn1nFIpdYJ25s9jI869oue9pnoj8u =Puyv -----END PGP SIGNATURE----- --u/L2/WlOHZg+YGU4--