git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: SZEDER GGGbor <szeder@ira.uka.de>
Cc: Jeff King <peff@peff.net>, vim@tpope.info, git@vger.kernel.org
Subject: Re: [RFC/PATCH] remove vim syntax highlighting in favor of upstream
Date: Mon, 29 Sep 2008 07:55:42 -0700	[thread overview]
Message-ID: <20080929145542.GA18340@spearce.org> (raw)
In-Reply-To: <20080924195658.GB6816@neumann>

SZEDER GGGbor <szeder@ira.uka.de> wrote:
> remove vim syntax highlighting in favor of upstream
> 
> As of version 7.2, vim ships with its own syntax
> highlighting for git commit messages, which is:
> 
>   1. more comprehensive in splitting up the various
>      components of the file
> 
>   2. in accordance with the usual vim behavior for syntax
>      highlighting (e.g., respecting b:current_syntax)
> 
>   3. presumably better maintained (I have not been using
>      what's in git's contrib/ directory for some time in
>      favor of the upstream version)
> 
> Furthermore, vim 7.2 also provides syntax highlighting for
> other git filetypes (gitconfig, rebase, send-email).
> 
> This patch gets rid of our local version and just points
> interested parties to the upstream version.
> 
> The code for auto-detecting filetypes is taken from vim 7.2's
> runtime/filetype.vim.
> 
> ---
>  contrib/vim/README               |   38 ++++++++++++++++++++++++++++++--------
>  contrib/vim/syntax/gitcommit.vim |   18 ------------------
>  2 files changed, 30 insertions(+), 26 deletions(-)
>  delete mode 100644 contrib/vim/syntax/gitcommit.vim

Missing SBO line?
 
-- 
Shawn.

  parent reply	other threads:[~2008-09-29 14:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24 15:22 [PATCH] vim syntax: highlight the diff in commit message template SZEDER Gábor
2008-09-24 15:57 ` Jeff King
2008-09-24 17:01   ` SZEDER Gábor
2008-09-24 17:53     ` [RFC/PATCH] remove vim syntax highlighting in favor of upstream Jeff King
2008-09-24 18:07       ` Shawn O. Pearce
2008-09-24 18:39       ` Garry Dolley
2008-09-24 19:56       ` SZEDER Gábor
2008-09-24 19:59         ` Jeff King
2008-09-25 12:48         ` SZEDER Gábor
2008-09-25 14:00           ` Bob Hiestand
2008-09-29 14:55         ` Shawn O. Pearce [this message]
2008-09-29 20:08           ` [PATCH] " SZEDER Gábor
2008-09-29 20:12             ` Jeff King
2008-09-30  8:29             ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080929145542.GA18340@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    --cc=vim@tpope.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).