From: Dmitry Potapov <dpotapov@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Johannes Sixt <johannes.sixt@telecom.at>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Alex Riesen <raa.lkml@gmail.com>, Marcus Griep <marcus@griep.us>
Subject: Re: [PATCH 4/4] cygwin: Use native Win32 API for stat
Date: Mon, 29 Sep 2008 22:26:00 +0400 [thread overview]
Message-ID: <20080929182600.GI21650@dpotapov.dyndns.org> (raw)
In-Reply-To: <20080929153400.GJ17584@spearce.org>
On Mon, Sep 29, 2008 at 08:34:00AM -0700, Shawn O. Pearce wrote:
> Johannes Sixt <johannes.sixt@telecom.at> wrote:
>
> > My point is that emphasis on "stat" in the name is wrong: That's about
> > implementation, but not about the effect. Why wouldn't 'ignoreCygwinFSTricks'
> > be specific enough?
>
> I like this a lot better. I could see us also bypassing other Cygwin
> functions like open() in order to get faster system calls for Git.
If you think that it may be useful to bypass some other functions, and
you want to use the same option to control that then a general name like
that makes sense. Personally, I don't believe that we may want to bypass
something like open() as it is not performance critical, but I said
above I don't care about the name much, so I am going to change my patch
to use ignoreCygwinFSTricks.
Dmitry
next prev parent reply other threads:[~2008-09-29 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 8:43 [PATCH 4/4] cygwin: Use native Win32 API for stat Dmitry Potapov
[not found] ` <347507080809270851y79764dbcgba1ef5a1d58bdd3e@mail.gmail.com>
2008-09-27 16:33 ` Dmitry Potapov
2008-09-27 18:35 ` Johannes Sixt
2008-09-27 21:54 ` Dmitry Potapov
2008-09-28 9:24 ` Johannes Sixt
2008-09-29 15:34 ` Shawn O. Pearce
2008-09-29 18:26 ` Dmitry Potapov [this message]
2008-09-30 13:53 ` [PATCH 4/4 v2] " Dmitry Potapov
2008-09-30 14:57 ` Marcus Griep
2008-09-30 20:26 ` Shawn O. Pearce
2008-09-28 9:50 ` [PATCH 4/4] " Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929182600.GI21650@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
--cc=marcus@griep.us \
--cc=raa.lkml@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).