From: Jeff King <peff@peff.net>
To: Mike Ralphson <mike.ralphson@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH] tests: grep portability fixes
Date: Tue, 30 Sep 2008 08:44:13 -0400 [thread overview]
Message-ID: <20080930124413.GA22078@coredump.intra.peff.net> (raw)
In-Reply-To: <e2b179460809300410q47592f63y7f7ec626007ad838@mail.gmail.com>
On Tue, Sep 30, 2008 at 12:10:19PM +0100, Mike Ralphson wrote:
> > There is one exception for "-e" here, which is in t7701 used
> > to produce an "or" of patterns. This can be rewritten as an
> > egrep pattern.
> >
> > This patch also removes use of "grep -F" in favor of the
> > more widely available "fgrep".
>
> Works here too (AIX 5.3)
>
> Tested-by: Mike Ralphson <mike@abacus.co.uk>
Thanks Mike and Johannes. The dropping of "-e" and "-q" we had done
before, but this was our first use of egrep and fgrep. From my
(admittedly limited) knowledge, I think they are fine, but it is nice to
have some confirmation.
-Peff
prev parent reply other threads:[~2008-09-30 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 8:03 [PATCH] tests: grep portability fixes Jeff King
2008-09-30 10:12 ` Andreas Ericsson
2008-09-30 10:29 ` Johannes Sixt
2008-09-30 12:45 ` Jeff King
2008-09-30 10:25 ` Johannes Sixt
2008-09-30 11:10 ` Mike Ralphson
2008-09-30 12:44 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930124413.GA22078@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=mike.ralphson@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).