From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Andreas Ericsson <ae@op5.se>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH] tests: grep portability fixes
Date: Tue, 30 Sep 2008 08:45:22 -0400 [thread overview]
Message-ID: <20080930124522.GA22182@coredump.intra.peff.net> (raw)
In-Reply-To: <48E1FF6D.1050907@viscovery.net>
On Tue, Sep 30, 2008 at 12:29:01PM +0200, Johannes Sixt wrote:
> Andreas Ericsson schrieb:
> > Jeff King wrote:
> >> - if ! grep -qe "Invalid gitfile format" .err
> >> + if ! grep "Invalid gitfile format" .err
> >
> > Doesn't output need to be redirected when you drop '-q'?
>
> In standard mode, the test output is directed to /dev/null anyway, and in
> verbose mode the extra output doesn't hurt at all, and is usually useful
> because you know that a pattern matched.
Exactly. This is the more of the same as aadbe44f (grep portability fix:
don't use "e" or "-q") but I was too lazy to rewrite the justification
completely (but I did reference it).
-Peff
next prev parent reply other threads:[~2008-09-30 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 8:03 [PATCH] tests: grep portability fixes Jeff King
2008-09-30 10:12 ` Andreas Ericsson
2008-09-30 10:29 ` Johannes Sixt
2008-09-30 12:45 ` Jeff King [this message]
2008-09-30 10:25 ` Johannes Sixt
2008-09-30 11:10 ` Mike Ralphson
2008-09-30 12:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930124522.GA22182@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).