* [PATCH] Documentation: remove '\' from front of options in githooks doc
@ 2008-09-30 13:37 SZEDER Gábor
2008-09-30 15:56 ` Thomas Rast
0 siblings, 1 reply; 4+ messages in thread
From: SZEDER Gábor @ 2008-09-30 13:37 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git, SZEDER Gábor
... because they show up in the man and html outputs.
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
Documentation/githooks.txt | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index 046a2a7..5bb7b33 100644
--- a/Documentation/githooks.txt
+++ b/Documentation/githooks.txt
@@ -66,7 +66,7 @@ pre-commit
----------
This hook is invoked by 'git-commit', and can be bypassed
-with `\--no-verify` option. It takes no parameter, and is
+with `--no-verify` option. It takes no parameter, and is
invoked before obtaining the proposed commit log message and
making a commit. Exiting with non-zero status from this script
causes the 'git-commit' to abort.
@@ -87,17 +87,17 @@ default log message, and before the editor is started.
It takes one to three parameters. The first is the name of the file
that the commit log message. The second is the source of the commit
-message, and can be: `message` (if a `\-m` or `\-F` option was
-given); `template` (if a `\-t` option was given or the
+message, and can be: `message` (if a `-m` or `-F` option was
+given); `template` (if a `-t` option was given or the
configuration option `commit.template` is set); `merge` (if the
commit is a merge or a `.git/MERGE_MSG` file exists); `squash`
(if a `.git/SQUASH_MSG` file exists); or `commit`, followed by
-a commit SHA1 (if a `\-c`, `\-C` or `\--amend` option was given).
+a commit SHA1 (if a `-c`, `-C` or `--amend` option was given).
If the exit status is non-zero, 'git-commit' will abort.
The purpose of the hook is to edit the message file in place, and
-it is not suppressed by the `\--no-verify` option. A non-zero exit
+it is not suppressed by the `--no-verify` option. A non-zero exit
means a failure of the hook and aborts the commit. It should not
be used as replacement for pre-commit hook.
@@ -108,7 +108,7 @@ commit-msg
----------
This hook is invoked by 'git-commit', and can be bypassed
-with `\--no-verify` option. It takes a single parameter, the
+with `--no-verify` option. It takes a single parameter, the
name of the file that holds the proposed commit log message.
Exiting with non-zero status causes the 'git-commit' to
abort.
--
1.6.0.2.448.g0c4e5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: remove '\' from front of options in githooks doc
2008-09-30 13:37 [PATCH] Documentation: remove '\' from front of options in githooks doc SZEDER Gábor
@ 2008-09-30 15:56 ` Thomas Rast
2008-09-30 17:21 ` SZEDER Gábor
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Rast @ 2008-09-30 15:56 UTC (permalink / raw)
To: SZEDER Gábor; +Cc: Shawn O. Pearce, git
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
SZEDER Gábor wrote:
> ... because they show up in the man and html outputs.
...
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
...
> @@ -66,7 +66,7 @@ pre-commit
> ----------
>
> This hook is invoked by 'git-commit', and can be bypassed
> -with `\--no-verify` option. It takes no parameter, and is
> +with `--no-verify` option. It takes no parameter, and is
> invoked before obtaining the proposed commit log message and
> making a commit. Exiting with non-zero status from this script
> causes the 'git-commit' to abort.
This must be checked against older asciidocs to verify that it does
not turn the unescaped sequence -- into an em-dash. The \-- traces
back to e1ccf53 ([PATCH] Escape asciidoc's built-in em-dash
replacement, 2005-09-12), which indicates that it _was_ a problem in
the past. (The asciidoc 8.2.5 on my system does not use an em-dash in
either case.)
ACK on all single-dash cases though, which are indeed wrong and were
apparently introduced later in 8089c85 (git-commit: add a
prepare-commit-msg hook, 2008-02-05).
- Thomas
--
Thomas Rast
trast@student.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: remove '\' from front of options in githooks doc
2008-09-30 15:56 ` Thomas Rast
@ 2008-09-30 17:21 ` SZEDER Gábor
2008-09-30 17:27 ` [PATCH] Documentation: remove '\' in front of short options SZEDER Gábor
0 siblings, 1 reply; 4+ messages in thread
From: SZEDER Gábor @ 2008-09-30 17:21 UTC (permalink / raw)
To: Thomas Rast; +Cc: Shawn O. Pearce, git
Hi Thomas,
On Tue, Sep 30, 2008 at 05:56:32PM +0200, Thomas Rast wrote:
> This must be checked against older asciidocs to verify that it does
> not turn the unescaped sequence -- into an em-dash. The \-- traces
> back to e1ccf53 ([PATCH] Escape asciidoc's built-in em-dash
> replacement, 2005-09-12), which indicates that it _was_ a problem in
> the past. (The asciidoc 8.2.5 on my system does not use an em-dash in
> either case.)
Indeed, now that I look more closely, I had those '\' characters only
in front of short options in the outputs.
However, it worth noting that there are plenty other places where
the double dash in long options are not escaped with a '\'.
> ACK on all single-dash cases though, which are indeed wrong and were
> apparently introduced later in 8089c85 (git-commit: add a
> prepare-commit-msg hook, 2008-02-05).
I will send a corrected patch shortly.
Thanks,
Gábor
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Documentation: remove '\' in front of short options
2008-09-30 17:21 ` SZEDER Gábor
@ 2008-09-30 17:27 ` SZEDER Gábor
0 siblings, 0 replies; 4+ messages in thread
From: SZEDER Gábor @ 2008-09-30 17:27 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: Thomas Rast, git
... because they show up in the man and html outputs.
This escaping is only needed for double dashes to be compatible with
older asciidoc versions; see commit e1ccf53 ([PATCH] Escape asciidoc's
built-in em-dash replacement, 2005-09-12).
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
Documentation/git-rev-list.txt | 6 +++---
Documentation/githooks.txt | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt
index fd1de92..1c9cc28 100644
--- a/Documentation/git-rev-list.txt
+++ b/Documentation/git-rev-list.txt
@@ -32,9 +32,9 @@ SYNOPSIS
[ \--cherry-pick ]
[ \--encoding[=<encoding>] ]
[ \--(author|committer|grep)=<pattern> ]
- [ \--regexp-ignore-case | \-i ]
- [ \--extended-regexp | \-E ]
- [ \--fixed-strings | \-F ]
+ [ \--regexp-ignore-case | -i ]
+ [ \--extended-regexp | -E ]
+ [ \--fixed-strings | -F ]
[ \--date={local|relative|default|iso|rfc|short} ]
[ [\--objects | \--objects-edge] [ \--unpacked ] ]
[ \--pretty | \--header ]
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index 046a2a7..7fefdb1 100644
--- a/Documentation/githooks.txt
+++ b/Documentation/githooks.txt
@@ -87,12 +87,12 @@ default log message, and before the editor is started.
It takes one to three parameters. The first is the name of the file
that the commit log message. The second is the source of the commit
-message, and can be: `message` (if a `\-m` or `\-F` option was
-given); `template` (if a `\-t` option was given or the
+message, and can be: `message` (if a `-m` or `-F` option was
+given); `template` (if a `-t` option was given or the
configuration option `commit.template` is set); `merge` (if the
commit is a merge or a `.git/MERGE_MSG` file exists); `squash`
(if a `.git/SQUASH_MSG` file exists); or `commit`, followed by
-a commit SHA1 (if a `\-c`, `\-C` or `\--amend` option was given).
+a commit SHA1 (if a `-c`, `-C` or `\--amend` option was given).
If the exit status is non-zero, 'git-commit' will abort.
--
1.6.0.2.448.g0c4e5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-30 17:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-30 13:37 [PATCH] Documentation: remove '\' from front of options in githooks doc SZEDER Gábor
2008-09-30 15:56 ` Thomas Rast
2008-09-30 17:21 ` SZEDER Gábor
2008-09-30 17:27 ` [PATCH] Documentation: remove '\' in front of short options SZEDER Gábor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).