git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Bryson <david@statichacks.org>
To: git@vger.kernel.org
Subject: [PATCH] Use "git_config_string" to simplify "builtin-gc.c" code where "prune_expire" is set
Date: Tue, 30 Sep 2008 12:05:49 -0700	[thread overview]
Message-ID: <20080930190549.GA9869@eratosthenes.cryptobackpack.org> (raw)

Hi all,
This is a quick janitor patch and my first patch sent to the git mailing
list.  Please let me know if I have done any process of the patch
submission wrong, and if I got the Janitorial task done in the proper
fashion.

Signed-off-by: David Bryson <david@statichacks.org>
---
 builtin-gc.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/builtin-gc.c b/builtin-gc.c
index fac200e..6260652 100644
--- a/builtin-gc.c
+++ b/builtin-gc.c
@@ -57,15 +57,12 @@ static int gc_config(const char *var, const char *value, void *cb)
 		return 0;
 	}
 	if (!strcmp(var, "gc.pruneexpire")) {
-		if (!value)
-			return config_error_nonbool(var);
-		if (strcmp(value, "now")) {
+		if (value && strcmp(value, "now")) {
 			unsigned long now = approxidate("now");
 			if (approxidate(value) >= now)
 				return error("Invalid %s: '%s'", var, value);
 		}
-		prune_expire = xstrdup(value);
-		return 0;
+		return git_config_string(&prune_expire, var, value);
 	}
 	return git_default_config(var, value, cb);
 }
-- 
1.6.0.2

             reply	other threads:[~2008-09-30 19:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30 19:05 David Bryson [this message]
2008-09-30 19:37 ` [PATCH] Use "git_config_string" to simplify "builtin-gc.c" code where "prune_expire" is set Shawn O. Pearce
2008-09-30 19:53 ` David Bryson
2008-09-30 20:04   ` Shawn O. Pearce
2008-09-30 20:28 ` David Bryson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930190549.GA9869@eratosthenes.cryptobackpack.org \
    --to=david@statichacks.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).