From: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [GUILT] Use git_editor
Date: Tue, 30 Sep 2008 16:22:26 -0400 [thread overview]
Message-ID: <20080930202226.GP32444@josefsipek.net> (raw)
In-Reply-To: <48E27A87.9060205@tuffmail.co.uk>
On Tue, Sep 30, 2008 at 08:14:15PM +0100, Alan Jenkins wrote:
> Josef 'Jeff' Sipek wrote:
> > On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:
> >
> >> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> >>
> >> diff --git a/guilt b/guilt
> >> index 1cef7b9..8d023e9 100755
> >> --- a/guilt
> >> +++ b/guilt
> >> @@ -693,10 +693,6 @@ fi
> >> series="$GUILT_DIR/$branch/series"
> >> applied="$GUILT_DIR/$branch/status"
> >>
> >> -# determine an editor to use for anything interactive (fall back to vi)
> >> -editor="vi"
> >> -[ ! -z "$EDITOR" ] && editor="$EDITOR"
> >> -
> >>
> >
> > Looks good from a quick glance. Any chance there's a git_pager?
> >
> > Josef 'Jeff' Sipek.
>
> Not in git-sh-setup. I did check :-).
Interesting! There are definitely places in git that invoke _a_
pager...maybe there's a patch to git that need creating :)
Josef 'Jeff' Sipek.
--
Failure is not an option,
It comes bundled with your Microsoft product.
next prev parent reply other threads:[~2008-09-30 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 18:43 [GUILT] Use git_editor Alan Jenkins
2008-09-30 19:07 ` Josef 'Jeff' Sipek
2008-09-30 19:14 ` Alan Jenkins
2008-09-30 20:22 ` Josef 'Jeff' Sipek [this message]
2008-10-01 2:31 ` Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930202226.GP32444@josefsipek.net \
--to=jeffpc@josefsipek.net \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).