From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH, resent] fix openssl headers conflicting with custom SHA1 implementations
Date: Tue, 30 Sep 2008 13:51:22 -0700 [thread overview]
Message-ID: <20080930205122.GO21310@spearce.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0809301645340.3635@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
> On Tue, 30 Sep 2008, Shawn O. Pearce wrote:
> > Nicolas Pitre <nico@cam.org> wrote:
> > > On ARM I have the following compilation errors:
> > ...
> > > This is a bit ugly but given the rat nest of system includes we have I
> > > don't know how to solve this any better.
> >
> > Hmm. On Linux x86 with your change:
> >
> > In file included from imap-send.c:32:
> > cache.h: In function 'create_ce_mode':
> > cache.h:186: error: 'S_IFLNK' undeclared (first use in this function)
> >
> > I think that last hunk which moved the openssl includes to be before
> > cache.h is the problem.
>
> With that, my build on ARM bombs out with:
>
> CC imap-send.o
> In file included from /usr/include/openssl/kssl.h:71,
> from /usr/include/openssl/ssl.h:191,
> from imap-send.c:30:
> /usr/include/ctype.h:102: error: expected expression before ']' token
*sigh*
Yea, its a bit ugly due to the rats nest of system includes.
Right now I don't see how we can include your patch, it breaks a
major platform for us. But obviously my "fix" is also bogus and
won't get ARM working again.
Any other ideas we can try? 'cause I don't have any right now. :-|
--
Shawn.
next prev parent reply other threads:[~2008-09-30 20:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 20:22 [PATCH, resent] fix openssl headers conflicting with custom SHA1 implementations Nicolas Pitre
2008-09-30 20:39 ` Shawn O. Pearce
2008-09-30 20:46 ` Nicolas Pitre
2008-09-30 20:51 ` Shawn O. Pearce [this message]
2008-10-01 3:47 ` Jeff King
2008-10-01 15:54 ` Shawn O. Pearce
2008-10-01 16:04 ` Jeff King
2008-10-01 16:10 ` Shawn O. Pearce
2008-10-01 16:35 ` Nicolas Pitre
2008-10-01 16:39 ` Shawn O. Pearce
2008-10-01 18:05 ` [PATCH v2] " Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080930205122.GO21310@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).