git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Stephen Haberman <stephen@exigencecorp.com>
Cc: Andreas Ericsson <ae@op5.se>, git@vger.kernel.org
Subject: Re: interactive rebase not rebasing
Date: Wed, 1 Oct 2008 11:31:35 -0700	[thread overview]
Message-ID: <20081001183135.GL21310@spearce.org> (raw)
In-Reply-To: <20081001121321.5761fc7e.stephen@exigencecorp.com>

Stephen Haberman <stephen@exigencecorp.com> wrote:
> 
> > > I've attempted to do that. Now that I sent in the patch, if you could
> > > review it, I would appreciate your feedback.
> > 
> > I'm heading home from work now. I'll look it over tonight or tomorrow
> > morning.
> 
> Cool, thanks.
> 
> Question: how taboo is it to just add another test file?
> 
> I can suffer through getting it to work, but a t3409 would be much
> easier, and probably easier to read as well as a I could setup my own
> DAG instead of hacking onto 3404s.

Usually folks prefer to add stuff to an existing test file, but
if the DAG is already a mess and you need a different DAG I find
it easier to just add new test file.  Thus far Junio hasn't pushed
back when I've done that.  Maybe I'm just lucky.  :-)

-- 
Shawn.

  reply	other threads:[~2008-10-01 18:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29  4:50 interactive rebase not rebasing Stephen Haberman
2008-09-29  6:42 ` Andreas Ericsson
2008-10-01  6:03   ` Stephen Haberman
2008-10-01  7:50     ` Andreas Ericsson
2008-10-01 14:52       ` Stephen Haberman
2008-10-01 15:26         ` Andreas Ericsson
2008-10-01 17:13           ` Stephen Haberman
2008-10-01 18:31             ` Shawn O. Pearce [this message]
2008-10-01 21:26             ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081001183135.GL21310@spearce.org \
    --to=spearce@spearce.org \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=stephen@exigencecorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).